From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH 11/15] ide: PCI BMDMA initialization fixes
Date: Wed, 24 Oct 2007 21:37:44 +0400 [thread overview]
Message-ID: <471F82E8.2010907@ru.mvista.com> (raw)
In-Reply-To: <200710032359.32630.bzolnier@gmail.com>
Hello.
Bartlomiej Zolnierkiewicz wrote:
> [PATCH] ide: PCI BMDMA initialization fixes (take 2)
> * Set hwif->dma_base only if allocation of extra ports succeeds.
> While at it:
> * Move setting of hwif->dma_{base,master} from ide_{mapped_mmio,iomio}_dma()
> to ide_setup_dma().
> * Rename 'dma_base' argument to 'base' in ide_setup_dma() (to make the code
> obey 80-columns limit and increase its readability).
> * Remove stale ide_setup_dma() comment.
> v2:
> * Change to allocate hwif->dmatable_cpu before reserving I/O ports missed
> teardown code (spotted by Sergei). On the second thought this change is
> actually unnecessary so revert it in v2.
> * Make ide_release_dma_engine() void and remove needless comment.
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
MBR, Sergei
prev parent reply other threads:[~2007-10-24 17:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-01 21:38 [PATCH 11/15] ide: PCI BMDMA initialization fixes Bartlomiej Zolnierkiewicz
2007-10-03 13:13 ` Sergei Shtylyov
2007-10-03 21:59 ` Bartlomiej Zolnierkiewicz
2007-10-24 17:37 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=471F82E8.2010907@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).