[PATCH] ata: sata_nv MCP61 using GENERIC instead of SWNCQ

[PATCH] ata: sata_nv MCP61 using GENERIC instead of SWNCQ

[Kuan Luo]

[-- Attachment #1: Type: text/plain, Size: 627 bytes --]

hi, 
	The mcp61 has bug with ncq. The patch only changes SWNCQ to
GENERIC  on MCP61 in nv_pci_tbl structure.

Best regards,
Kuan Luo

-----------------------------------------------------------------------------------
This email message is for the sole use of the intended recipient(s) and may contain
confidential information.  Any unauthorized review, use, disclosure or distribution
is prohibited.  If you are not the intended recipient, please contact the sender by
reply email and destroy all copies of the original message.
-----------------------------------------------------------------------------------

[-- Attachment #2: sata_nv-mcp61-generic-patch --]
[-- Type: application/octet-stream, Size: 927 bytes --]

diff --git a/drivers/ata/sata_nv.c b/drivers/ata/sata_nv.c
index 240a892..8e5597a 100644
--- a/drivers/ata/sata_nv.c
+++ b/drivers/ata/sata_nv.c
@@ -365,9 +365,9 @@ static const struct pci_device_id nv_pci_tbl[] = {
 	{ PCI_VDEVICE(NVIDIA, PCI_DEVICE_ID_NVIDIA_NFORCE_MCP51_SATA2), SWNCQ },
 	{ PCI_VDEVICE(NVIDIA, PCI_DEVICE_ID_NVIDIA_NFORCE_MCP55_SATA), SWNCQ },
 	{ PCI_VDEVICE(NVIDIA, PCI_DEVICE_ID_NVIDIA_NFORCE_MCP55_SATA2), SWNCQ },
-	{ PCI_VDEVICE(NVIDIA, PCI_DEVICE_ID_NVIDIA_NFORCE_MCP61_SATA), SWNCQ },
-	{ PCI_VDEVICE(NVIDIA, PCI_DEVICE_ID_NVIDIA_NFORCE_MCP61_SATA2), SWNCQ },
-	{ PCI_VDEVICE(NVIDIA, PCI_DEVICE_ID_NVIDIA_NFORCE_MCP61_SATA3), SWNCQ },
+	{ PCI_VDEVICE(NVIDIA, PCI_DEVICE_ID_NVIDIA_NFORCE_MCP61_SATA), GENERIC },
+	{ PCI_VDEVICE(NVIDIA, PCI_DEVICE_ID_NVIDIA_NFORCE_MCP61_SATA2), GENERIC },
+	{ PCI_VDEVICE(NVIDIA, PCI_DEVICE_ID_NVIDIA_NFORCE_MCP61_SATA3), GENERIC },
 
 	{ } /* terminate list */
 };

Re: [PATCH] ata: sata_nv MCP61 using GENERIC instead of SWNCQ

[Andrew Morton]

On Mon, 22 Oct 2007 14:00:56 +0800 "Kuan Luo" <kluo@nvidia.com> wrote:

> 	The mcp61 has bug with ncq. The patch only changes SWNCQ to
> GENERIC  on MCP61 in nv_pci_tbl structure.

Please include a Signed-off-by: in your patches, as per
Documentation/SubmittingPatches, thanks.

Re: [PATCH] ata: sata_nv MCP61 using GENERIC instead of SWNCQ

[Jeff Garzik]

Kuan Luo wrote:
> hi, 
> 	The mcp61 has bug with ncq. The patch only changes SWNCQ to
> GENERIC  on MCP61 in nv_pci_tbl structure.

Do I have your permission to merge this patch with a

	Signed-off-by: Kuan Luo <kluo@nvidia.com>

?

Each patch needs a Signed-off-By line, which essentially provides a 
legal release to the patch.  See "Developer's Certificate of Origin" in 
Documentation/SubmittingPatches or
http://linux.yyz.us/patch-format.html

	Jeff

RE: [PATCH] ata: sata_nv MCP61 using GENERIC instead of SWNCQ

[Kuan Luo]

jeff wrote:
> Kuan Luo wrote:
> > hi, 
> > 	The mcp61 has bug with ncq. The patch only changes SWNCQ to
> > GENERIC  on MCP61 in nv_pci_tbl structure.
> 
> Do I have your permission to merge this patch with a
> 
> 	Signed-off-by: Kuan Luo <kluo@nvidia.com>
> 
> ?
> 
> Each patch needs a Signed-off-By line, which essentially provides a 
> legal release to the patch.  See "Developer's Certificate of 
> Origin" in 
> Documentation/SubmittingPatches or
> http://linux.yyz.us/patch-format.html
> 
> 	Jeff
> 
> 
>
Yes, you can merge Signed-off-by: Kuan Luo <kluo@nvidia.com>. 
Next time  i will sumbit the patch according completely with the patch
format.

Best regards,
Kuan Luo
-----------------------------------------------------------------------------------
This email message is for the sole use of the intended recipient(s) and may contain
confidential information.  Any unauthorized review, use, disclosure or distribution
is prohibited.  If you are not the intended recipient, please contact the sender by
reply email and destroy all copies of the original message.
-----------------------------------------------------------------------------------

Re: [PATCH] ata: sata_nv MCP61 using GENERIC instead of SWNCQ

[Jeff Garzik]

Kuan Luo wrote:
> hi, 
> 	The mcp61 has bug with ncq. The patch only changes SWNCQ to
> GENERIC  on MCP61 in nv_pci_tbl structure.

applied