From: Jeff Garzik <jeff@garzik.org>
To: David Miller <davem@davemloft.net>
Cc: linux-kernel@vger.kernel.org, barkalow@iabervon.org,
linas@austin.ibm.com, chunhao.huang@hotmail.com, gregkh@suse.de,
htejun@gmail.com, brice.goglin@gmail.com,
david.gaarenstroom@gmail.com, linux-pci@atrey.karlin.mff.cuni.cz,
shane.huang@amd.com, linux-ide@vger.kernel.org, brice@myri.com,
mchan@broadcom.com
Subject: Re: [PATCH 0/4]: Resolve MSI vs. INTX_DISABLE quirks.
Date: Thu, 25 Oct 2007 01:37:47 -0400 [thread overview]
Message-ID: <47202BAB.2040709@garzik.org> (raw)
In-Reply-To: <20071023.195108.69018458.davem@davemloft.net>
David Miller wrote:
> The forthcoming patches are also available from:
>
> kernel.org:/pub/scm/linux/kernel/git/davem/msiquirk-2.6.git
>
> and clean up the handling of the common quirk wherein setting
> INTX_DISABLE will mistakedly disable MSI generation for some
> devices.
>
> For devices without that problem, we want to keep the pci_intx() calls
> in drivers/pci/msi.c because those help protect against devices
> with the opposite problem. Such devices always generate INTX
> interrupts even when MSI is enabled, unless INTX_DISABLE is set.
>
> Michael, please pay special attention to patch #3. I think I
> picked the correct PCI device IDs to match for the quirk
> (5714* and 5780*) but it's possible we might need more elaborate
> checks here. It at least worked properly for the chips in my
> Niagara system.
>
> In addition to the Tigon3 cases, I added quirk entries for the
> SB700/800 SATA chips and the IXP SB400 USB controllers.
>
> Signed-off-by: David S. Miller <davem@davemloft.net>
I'm happy with this patch series. A quirk is better than a
sledgehammer, and MSI-mode SATA is better than INTX-mode SATA :)
Jeff
prev parent reply other threads:[~2007-10-25 5:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-24 2:51 [PATCH 0/4]: Resolve MSI vs. INTX_DISABLE quirks David Miller
2007-10-24 4:58 ` Daniel Barkalow
2007-10-24 5:06 ` David Miller
2007-10-24 16:52 ` Daniel Barkalow
2007-10-25 5:37 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47202BAB.2040709@garzik.org \
--to=jeff@garzik.org \
--cc=barkalow@iabervon.org \
--cc=brice.goglin@gmail.com \
--cc=brice@myri.com \
--cc=chunhao.huang@hotmail.com \
--cc=davem@davemloft.net \
--cc=david.gaarenstroom@gmail.com \
--cc=gregkh@suse.de \
--cc=htejun@gmail.com \
--cc=linas@austin.ibm.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=mchan@broadcom.com \
--cc=shane.huang@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).