From: Jeff Garzik <jeff@garzik.org>
To: Tejun Heo <htejun@gmail.com>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH] libata: cosmetic clean up in ata_eh_reset()
Date: Thu, 25 Oct 2007 02:02:12 -0400 [thread overview]
Message-ID: <47203164.9000801@garzik.org> (raw)
In-Reply-To: <20071024062126.GD11853@htj.dyndns.org>
Tejun Heo wrote:
> Local variable @action usage in ata_eh_reset() is a bit confusing.
> It's used only to cache ehc->i.action to test reset masks after
> clearing it; however, due to the generic name "action", it's easy to
> misinterpret the local variable as containing the selected reset
> method later. Also, the reason for caching the original value is easy
> to miss.
>
> This patch renames @action to @tmp_action and make it buffer newly
> selected value instead to improve readability.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
> ---
> drivers/ata/libata-eh.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
applied
prev parent reply other threads:[~2007-10-25 6:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-24 6:21 [PATCH] libata: cosmetic clean up in ata_eh_reset() Tejun Heo
2007-10-25 6:02 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47203164.9000801@garzik.org \
--to=jeff@garzik.org \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).