From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [PATCH 0/5]: Resolve MSI vs. INTX_DISABLE quirks, V2. Date: Thu, 25 Oct 2007 04:24:33 -0400 Message-ID: <472052C1.2050302@garzik.org> References: <20071025.011445.80152909.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from srv5.dvmed.net ([207.36.208.214]:60498 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752115AbXJYIYh (ORCPT ); Thu, 25 Oct 2007 04:24:37 -0400 In-Reply-To: <20071025.011445.80152909.davem@davemloft.net> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: David Miller Cc: linux-kernel@vger.kernel.org, barkalow@iabervon.org, linas@austin.ibm.com, chunhao.huang@hotmail.com, gregkh@suse.de, htejun@gmail.com, brice.goglin@gmail.com, david.gaarenstroom@gmail.com, linux-pci@atrey.karlin.mff.cuni.cz, shane.huang@amd.com, linux-ide@vger.kernel.org, brice@myri.com, mchan@broadcom.com David Miller wrote: > Ok, I've respun the patches including all of the feedback I've > obtained. Again, it's at: > > kernel.org:/pub/scm/linux/kernel/git/davem/msiquirk-2.6.git > > Greg, I think this stuff is ready to go so if you would pull > them in I would really appreciate it. > > These changes clean up the handling of the common quirk wherein > setting INTX_DISABLE will mistakedly disable MSI generation for some > devices. > > For devices without that problem, we want to keep the pci_intx() calls > in drivers/pci/msi.c because those help protect against devices with > the opposite problem. Such devices always generate INTX interrupts > even when MSI is enabled, unless INTX_DISABLE is set. > > In addition to the Tigon3 cases, I added quirk entries for the > SB700/800 SATA chips and the IXP SB400 USB controllers. And as > a result of the latter we can remove several AMD full-chipset > MSI disable quirks which are no longer necessary. > > Signed-off-by: David S. Miller [corrected subject line s/4/5/. the actual patches are OK] Acked-by: Jeff Garzik