From: Jeff Garzik <jeff@garzik.org>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: Andrew <andrew@nelless.net>,
linux-ide@vger.kernel.org, Kuan Luo <kluo@nvidia.com>
Subject: Re: 2.6.24-rc1, sata_nv: MCP51 is boned with SWNCQ too
Date: Thu, 25 Oct 2007 08:35:56 -0400 [thread overview]
Message-ID: <47208DAC.1000207@garzik.org> (raw)
In-Reply-To: <200710251411.42546.bzolnier@gmail.com>
Bartlomiej Zolnierkiewicz wrote:
> @@ -2379,9 +2379,13 @@ static int nv_init_one (struct pci_dev *
> if (type == CK804 && adma_enabled) {
> dev_printk(KERN_NOTICE, &pdev->dev, "Using ADMA mode\n");
> type = ADMA;
> + } else if (type == GENERIC && swncq_enabled) {
> + dev_printk(KERN_NOTICE, &pdev->dev, "Using SWNCQ mode\n");
> + type = SWNCQ;
> }
>
If we want to start putting PCI_ANY_ID entries in the pci_device_id
table (as other NVIDIA patches have proposed), I don't think it's safe
to assume that all devices marked GENERIC can do SWNCQ, while it should
be safe to fall back from SWNCQ to GENERIC. GENERIC is the selection
being considered for use as being compatible with future chips.
But overall both patches look straightforward...
Jeff
next prev parent reply other threads:[~2007-10-25 12:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-25 9:54 2.6.24-rc1, sata_nv: MCP51 is boned with SWNCQ too Andrew
2007-10-25 10:48 ` Jeff Garzik
2007-10-25 11:13 ` Andrew Nelless
2007-10-25 11:43 ` Bartlomiej Zolnierkiewicz
2007-10-25 11:47 ` Andrew
2007-10-25 12:06 ` Bartlomiej Zolnierkiewicz
2007-10-25 12:11 ` Bartlomiej Zolnierkiewicz
2007-10-25 12:35 ` Jeff Garzik [this message]
2007-10-25 14:03 ` Bartlomiej Zolnierkiewicz
2007-10-25 20:58 ` Andrew
2007-10-26 5:18 ` Kuan Luo
2007-10-26 13:26 ` Andrew
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47208DAC.1000207@garzik.org \
--to=jeff@garzik.org \
--cc=andrew@nelless.net \
--cc=bzolnier@gmail.com \
--cc=kluo@nvidia.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).