From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: linux-ide@vger.kernel.org, Tejun Heo <htejun@gmail.com>
Subject: Re: [PATCH 6/12] ide: add struct ide_taskfile
Date: Thu, 25 Oct 2007 20:37:33 +0400 [thread overview]
Message-ID: <4720C64D.3000902@ru.mvista.com> (raw)
In-Reply-To: <200710250016.29315.bzolnier@gmail.com>
Bartlomiej Zolnierkiewicz wrote:
>>>Index: b/drivers/ide/ide-disk.c
>>>===================================================================
>>>--- a/drivers/ide/ide-disk.c
>>>+++ b/drivers/ide/ide-disk.c
>>[...]
>>>+ if ((tf->command & 0x01) == 0) {
>>>+ u32 high, low;
>> Isn't newline needed after declarations?
> Well, it is not stricly needed, this code should compile and work without it.
> ;)
> fixed (FWIW the original code also lacked newline)
Yeah, I saw but that's hardly worth imitating. :-)
[...]
> New revision of the patch (it also uses the suggestion about using unnamed
> unions for error/feature and status/command, thanks!):
> [PATCH] ide: add struct ide_taskfile (take 2)
> * Don't set write-only ide_task_t.hobRegister[6] and ide_task_t.hobRegister[7]
> in idedisk_set_max_address_ext().
> * Add struct ide_taskfile and use it in ide_task_t instead of tfRegister[]
> and hobRegister[].
> * Remove no longer needed IDE_CONTROL_OFFSET_HOB define.
> * Add #ifndef/#endif __KERNEL__ around definitions of {task,hob}_struct_t.
> While at it:
> * Use ATA_LBA define for LBA bit (0x40) as suggested by Tejun Heo.
> v2:
> * Add missing newlines. (Noticed by Sergei)
> * Use ~ATA_LBA instead of 0xBF. (Noticed by Sergei)
> * Use unnamed unions for error/feature and status/command.
> (Suggested by Sergei).
> There should be no functionality changes caused by this patch.
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
> ---
> drivers/ide/ide-disk.c | 156 ++++++++++++++++++++++++---------------------
> drivers/ide/ide-io.c | 80 +++++++++++++----------
> drivers/ide/ide-iops.c | 12 +--
> drivers/ide/ide-lib.c | 3
> drivers/ide/ide-acpi.c | 8 ---
> drivers/ide/ide-disk.c | 120 +++++++++++++++++++++------------------------
> drivers/ide/ide-io.c | 61 ++++++++++++----------
> drivers/ide/ide-iops.c | 12 ++--
> drivers/ide/ide-lib.c | 3 -
Don't know how but ide-disk.c, ide-io[ps].c and ide-lib.c appear twice in
the diffstat output... 8-)
MBR, Sergei
next prev parent reply other threads:[~2007-10-25 16:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-08 21:11 [PATCH 6/12] ide: add struct ide_taskfile Bartlomiej Zolnierkiewicz
2007-10-17 17:38 ` Sergei Shtylyov
2007-10-24 22:16 ` Bartlomiej Zolnierkiewicz
2007-10-25 16:37 ` Sergei Shtylyov [this message]
2007-10-19 16:47 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4720C64D.3000902@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=bzolnier@gmail.com \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).