From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: Regression: commit "ide: constify struct ide_port_info" causes breakage Date: Fri, 26 Oct 2007 20:38:15 +0400 Message-ID: <472217F7.6060501@ru.mvista.com> References: <20071026155648.GB4321@flint.arm.linux.org.uk> <47221164.10200@ru.mvista.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from gateway-1237.mvista.com ([63.81.120.155]:58856 "EHLO imap.sh.mvista.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1752133AbXJZQiI (ORCPT ); Fri, 26 Oct 2007 12:38:08 -0400 In-Reply-To: Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Linus Torvalds Cc: Russell King , linux-ide@vger.kernel.org, Bartlomiej Zolnierkiewicz , Jeff Garzik , Alan Cox , Linux Kernel List , Andrew Morton Hello. Linus Torvalds wrote: >> We can just convert cariables declared as 'struct hpt_info' to const too -- >>they are read-only templates. > Generally "__devinitdata" is better than "const", since it means that the > data may be thrown away. Agreed. > So if you drop one over the other, No, just add 'const' to already __devinitdata data to make gcc happy again. > it's generally the "const" that should be dropped ;/ Well, this may break when/if we need to add __devinitdata that is actually r/w -- not likely with this driver but still... > Linus WBR, Sergei