From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH 8/9] ide: replace ide_pci_device_t by struct ide_port_info
Date: Sat, 27 Oct 2007 21:05:36 +0400 [thread overview]
Message-ID: <47236FE0.6020606@ru.mvista.com> (raw)
In-Reply-To: <200709242247.27459.bzolnier@gmail.com>
Bartlomiej Zolnierkiewicz wrote:
> * Rename struct ide_pci_device_s to struct ide_port_info.
I'm not sure that ide_port_info name fits the data indeed, as those are
not applicable only to the ports but to a chip as a whole, so ide_chip_info
would seem a better name... but well, it's too late anyway.
> * Remove ide_pci_device_t typedef.
> While at it:
> * Fix __ide_pci_register_driver() comment.
> * Fix aec62xx_init_one() comment.
> * Remove unused 'cds' field from ide_hwgroup_t.
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Well, it's too late for ACK. :-)
MBR, Sergei
next prev parent reply other threads:[~2007-10-27 17:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-24 20:47 [PATCH 8/9] ide: replace ide_pci_device_t by struct ide_port_info Bartlomiej Zolnierkiewicz
2007-10-27 17:05 ` Sergei Shtylyov [this message]
2007-10-27 17:34 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47236FE0.6020606@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).