From: Alexander Sabourenkov <screwdriver@lxnt.info>
To: Jeff Garzik <jeff@garzik.org>
Cc: Mikael Pettersson <mikpe@it.uu.se>, linux-ide@vger.kernel.org
Subject: Re: [PATCH 2.6.24-rc1] sata_promise: ASIC PRD table bug workaround
Date: Tue, 30 Oct 2007 09:09:27 +0300 [thread overview]
Message-ID: <4726CA97.3030609@lxnt.info> (raw)
In-Reply-To: <47262F5A.8070804@garzik.org>
Jeff Garzik wrote:
> Mikael Pettersson wrote:
>> @@ -530,7 +608,7 @@ static void pdc_qc_prep(struct ata_queue
>>
>> switch (qc->tf.protocol) {
>> case ATA_PROT_DMA:
>> - ata_qc_prep(qc);
>> + pdc_fill_sg(qc);
>> /* fall through */
>>
>> case ATA_PROT_NODATA:
>> @@ -546,11 +624,11 @@ static void pdc_qc_prep(struct ata_queue
>> break;
>>
>> case ATA_PROT_ATAPI:
>> - ata_qc_prep(qc);
>> + pdc_fill_sg(qc);
>> break;
>>
>> case ATA_PROT_ATAPI_DMA:
>> - ata_qc_prep(qc);
>> + pdc_fill_sg(qc);
>> /*FALLTHROUGH*/
>
> Note that this is not exactly an equivalent change -- you are removing
> the test in ata_qc_prep() that occurs prior to ata_fill_sg() call.
Not at all. The test is there at the beginning of pdc_fill_sg().
--
./lxnt
next prev parent reply other threads:[~2007-10-30 6:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-29 15:50 [PATCH 2.6.24-rc1] sata_promise: ASIC PRD table bug workaround Mikael Pettersson
2007-10-29 19:07 ` Jeff Garzik
2007-10-30 6:09 ` Alexander Sabourenkov [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-10-30 9:07 Mikael Pettersson
2007-10-30 9:22 ` Alexander Sabourenkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4726CA97.3030609@lxnt.info \
--to=screwdriver@lxnt.info \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
--cc=mikpe@it.uu.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).