From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH 13/15] ide: remove hwif->intrproc
Date: Thu, 01 Nov 2007 00:15:06 +0300 [thread overview]
Message-ID: <4728F05A.5000502@ru.mvista.com> (raw)
In-Reply-To: <200710310055.13329.bzolnier@gmail.com>
Hello.
Bartlomiej Zolnierkiewicz wrote:
> Given that:
> * hpt366.c::hpt3xx_intrproc() is the only user of hwif->intrproc
> * hpt366.c::hpt3xx_quirkproc() sets drive->quirk_list to 1 for quirky drives
> which is a value unique to hpt366 host driver
> we can remove hwif->intproc and just check for drive->quirk_list == 1
> in ide_do_request().
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
> ---
> Handling of quirky drives (problems with nIEN) by hpt366 and pdc202xx_*
> looks suspicious... are the problems really dependent on the host type
> (thus hwif->quirkproc and ->quirk_list == 1/2)? Shouldn't we just handle
> quirky drives in the same way in the core IDE code regardless of the host
> driver being used (of course using hwif->maskproc where needed)?
Indeed...
MBR, Sergei
next prev parent reply other threads:[~2007-10-31 21:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-30 23:55 [PATCH 13/15] ide: remove hwif->intrproc Bartlomiej Zolnierkiewicz
2007-10-31 21:15 ` Sergei Shtylyov [this message]
2007-11-08 0:51 ` Mark Lord
2007-11-08 2:43 ` Tejun Heo
2007-11-08 10:39 ` Alan Cox
2007-11-08 11:08 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4728F05A.5000502@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).