From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: Suspend to ram regression (2.6.24-rc1-git) Date: Thu, 01 Nov 2007 07:55:33 -0400 Message-ID: <4729BEB5.5080504@garzik.org> References: <20071031201308.GK11514@kernel.dk> <20071101084145.GA5037@kernel.dk> <20071101092155.GB5037@kernel.dk> <4729B670.7090403@garzik.org> <20071101112419.GE5037@kernel.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from srv5.dvmed.net ([207.36.208.214]:38841 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751009AbXKALzf (ORCPT ); Thu, 1 Nov 2007 07:55:35 -0400 In-Reply-To: <20071101112419.GE5037@kernel.dk> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Jens Axboe Cc: linux-kernel@vger.kernel.org, kristen.c.accardi@intel.com, linux-ide@vger.kernel.org Jens Axboe wrote: > On Thu, Nov 01 2007, Jeff Garzik wrote: >> Jens Axboe wrote: >>> Reverting just the default AHCI flags makes it work again. IOW, with the >>> below patch I can suspend properly with current -git. >>> diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c >>> index ed9b407..77f7631 100644 >>> --- a/drivers/ata/ahci.c >>> +++ b/drivers/ata/ahci.c >>> @@ -190,8 +190,7 @@ enum { >>> AHCI_FLAG_COMMON = ATA_FLAG_SATA | ATA_FLAG_NO_LEGACY | >>> ATA_FLAG_MMIO | ATA_FLAG_PIO_DMA | >>> - ATA_FLAG_ACPI_SATA | ATA_FLAG_AN | >>> - ATA_FLAG_IPM, >>> + ATA_FLAG_ACPI_SATA | ATA_FLAG_AN, >>> AHCI_LFLAG_COMMON = ATA_LFLAG_SKIP_D2H_BSY, >> >> sounds like the easy thing to do, in light of this breakage, might be to >> default it to off, add a module parameter turning it on by setting that >> flag. > > Wouldn't it be better to just get this bug fixed? IOW, is there a reason > for disabling ALPM if it's Bug Free? > > I'd suggest committing the patch disabling IPM, then Kristen can debug > the thing in piece in quiet. Once confident it works with ahci again, we > can revert that commit. Right -- if you are going to commit a patch "disabling" it, it is best to do so via a simple module option, which allows users to easily try the feature in parallel with Intel's debugging. Jeff