Re: [PATCH 3/3] pata_amd: fix and improve cable detection

[Tejun Heo <htejun@gmail.com>]

Alan Cox wrote:
>> Cable detection on Nvidia PATA hosts is pathetic.  The current
>> nv_cable_detect() assumes that the native cable detection only
>> mistakes 80c as 40c but this isn't true.  On ASUS A8N-E, cable
>> register almost always says 80c is attached and it also manages to
>> trick the drive that the cable is 80c.
> 
> According to the last Nvidia comments on Nvidia there is no cable detect
> bit. I've just never gotten around to implementing it because due to lack
> of documentation Nvidia PATA is very very low priority compared to
> problems with documented chipsets from helpful vendors.

Yeah, it seems some boards just say 80C while others just say 40C, so
all we can use is how the BIOS configured it.  I suppose BIOS does it by
issuing trial commands which I don't think adding to libata is a good idea.

Can you please lemme know what you don't like about the current
implementation or what other approach you have in mind?  I don't like
Nvidia PATA either but there are a lot of people using it out there.

Thanks.

-- 
tejun