From: Tejun Heo <htejun@gmail.com>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: jeff@garzik.org, linux-ide@vger.kernel.org
Subject: Re: [PATCH 3/8] libata: factor out ata_eh_schedule_probe()
Date: Mon, 05 Nov 2007 21:29:25 +0900 [thread overview]
Message-ID: <472F0CA5.7010800@gmail.com> (raw)
In-Reply-To: <200711051136.57793.bzolnier@gmail.com>
Bartlomiej Zolnierkiewicz wrote:
>> - if (!ata_dev_enabled(dev) &&
>> - ((ehc->i.probe_mask & (1 << dev->devno)) &&
>> - !(ehc->did_probe_mask & (1 << dev->devno)))) {
>> - ata_eh_detach_dev(dev);
>> - ata_dev_init(dev);
>> - ehc->did_probe_mask |= (1 << dev->devno);
>> - ehc->i.action |= ATA_EH_SOFTRESET;
>> - }
>> + /* schedule probe if necessary */
>> + ata_eh_schedule_probe(dev);
>
> !ata_dev_enabled() got lost, is this intended?
Definitely not. Thanks a lot for catching this. Jeff, I'll post an
updated version. Thanks.
--
tejun
next prev parent reply other threads:[~2007-11-05 12:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-05 5:45 [PATCHSET] libata: update EH speed down logic, take #2 Tejun Heo
2007-11-05 5:45 ` [PATCH 1/8] libata: rearrange ATA_DFLAG_* Tejun Heo
2007-11-05 5:45 ` [PATCH 2/8] libata: add protocol data transfer tests Tejun Heo
2007-11-05 5:45 ` [PATCH 3/8] libata: factor out ata_eh_schedule_probe() Tejun Heo
2007-11-05 10:36 ` Bartlomiej Zolnierkiewicz
2007-11-05 12:29 ` Tejun Heo [this message]
2007-11-06 4:53 ` [PATCH 3/8 UPDATED] " Tejun Heo
2007-11-05 5:45 ` [PATCH 4/8] libata: move ata_set_mode() to libata-eh.c Tejun Heo
2007-11-05 5:45 ` [PATCH 5/8] libata: clean up EH speed down implementation Tejun Heo
2007-11-05 5:45 ` [PATCH 6/8] libata: adjust speed down rules Tejun Heo
2007-11-05 5:45 ` [PATCH 7/8] libata: implement ATA_DFLAG_DUBIOUS_XFER Tejun Heo
2007-11-05 5:45 ` [PATCH 8/8] libata: implement fast speed down for unverified data transfer mode Tejun Heo
2007-11-23 1:07 ` [PATCHSET] libata: update EH speed down logic, take #2 Tejun Heo
2007-11-24 1:04 ` Jeff Garzik
-- strict thread matches above, loose matches on Subject: below --
2007-11-27 10:28 [PATCHSET] libata: improve EH speed down logic, take #3 Tejun Heo
2007-11-27 10:28 ` [PATCH 3/8] libata: factor out ata_eh_schedule_probe() Tejun Heo
2007-11-01 15:51 [PATCHSET] libata: update EH speed down logic Tejun Heo
2007-11-01 15:51 ` [PATCH 3/8] libata: factor out ata_eh_schedule_probe() Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=472F0CA5.7010800@gmail.com \
--to=htejun@gmail.com \
--cc=bzolnier@gmail.com \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).