Re: Suspend to ram regression (2.6.24-rc1-git)

[Jeff Garzik <jeff@garzik.org>]

Jens Axboe wrote:
> On Fri, Nov 02 2007, Kristen Carlson Accardi wrote:
>> On Thu, 1 Nov 2007 09:41:46 +0100
>> Jens Axboe <jens.axboe@oracle.com> wrote:
>>
>>> On Wed, Oct 31 2007, Jens Axboe wrote:
>>>> Hi,
>>>>
>>>> My x60 stopped suspending about two days ago. It just freezes after
>>>> printing
>>>>
>>>> Suspending console(s)
>>>>
>>>> where it would normally turn everything off and the 'moon' light would
>>>> go on. Posting this message in case somebody else knows what is up, if
>>>> not I'll do a bisect on it tomorrow.
>>> Did the bisect, it points to this commit:
>>>
>>> 1556594f913fa81d008cecfe46d7211c919a853 is first bad commit
>>> commit 31556594f913fa81d008cecfe46d7211c919a853
>>> Author: Kristen Carlson Accardi <kristen.c.accardi@intel.com>
>>> Date:   Thu Oct 25 01:33:26 2007 -0400
>>>
>>>     [libata] AHCI: add hw link power management support
>>>
>>> Booting any kernel after this commit fails suspending to ram, it just
>>> sits there forever.
>>>
>>> -- 
>>> Jens Axboe
>>>
>> Does this patch fix your problem?  It seems to get hung up while disabling
>> DIPM, and after thinking about this a bit, I don't think we really need
>> to do this anyway.
> 
> Yep, works for me! Can we get this expedited upstream?

If everybody's happy with it, I've got it ready for upstream in 
libata-dev.git#dlpm-fix

	Jeff