From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: Suspend to ram regression (2.6.24-rc1-git) Date: Mon, 05 Nov 2007 07:53:58 -0500 Message-ID: <472F1266.80207@garzik.org> References: <20071031201308.GK11514@kernel.dk> <20071101084145.GA5037@kernel.dk> <20071102163708.15304989.kristen.c.accardi@intel.com> <20071105124711.GF5359@kernel.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from srv5.dvmed.net ([207.36.208.214]:49667 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754912AbXKEMyE (ORCPT ); Mon, 5 Nov 2007 07:54:04 -0500 In-Reply-To: <20071105124711.GF5359@kernel.dk> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Jens Axboe Cc: Kristen Carlson Accardi , linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org Jens Axboe wrote: > On Fri, Nov 02 2007, Kristen Carlson Accardi wrote: >> On Thu, 1 Nov 2007 09:41:46 +0100 >> Jens Axboe wrote: >> >>> On Wed, Oct 31 2007, Jens Axboe wrote: >>>> Hi, >>>> >>>> My x60 stopped suspending about two days ago. It just freezes after >>>> printing >>>> >>>> Suspending console(s) >>>> >>>> where it would normally turn everything off and the 'moon' light would >>>> go on. Posting this message in case somebody else knows what is up, if >>>> not I'll do a bisect on it tomorrow. >>> Did the bisect, it points to this commit: >>> >>> 1556594f913fa81d008cecfe46d7211c919a853 is first bad commit >>> commit 31556594f913fa81d008cecfe46d7211c919a853 >>> Author: Kristen Carlson Accardi >>> Date: Thu Oct 25 01:33:26 2007 -0400 >>> >>> [libata] AHCI: add hw link power management support >>> >>> Booting any kernel after this commit fails suspending to ram, it just >>> sits there forever. >>> >>> -- >>> Jens Axboe >>> >> Does this patch fix your problem? It seems to get hung up while disabling >> DIPM, and after thinking about this a bit, I don't think we really need >> to do this anyway. > > Yep, works for me! Can we get this expedited upstream? If everybody's happy with it, I've got it ready for upstream in libata-dev.git#dlpm-fix Jeff