* [PATCH 2/18] ide-pmac: skip conservative PIO "downgrade"
@ 2007-11-04 23:17 Bartlomiej Zolnierkiewicz
2007-11-04 23:35 ` Benjamin Herrenschmidt
2007-11-06 11:30 ` Sergei Shtylyov
0 siblings, 2 replies; 3+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2007-11-04 23:17 UTC (permalink / raw)
To: linux-ide; +Cc: Mikael Pettersson, Benjamin Herrenschmidt
We can skip conservative PIO "downgrade" (PIO3 becomes PIO2 etc.) on PMAC.
Problem reported by Mikael.
Cc: Mikael Pettersson <mikpe@it.uu.se>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
---
drivers/ide/ppc/pmac.c | 1 +
1 file changed, 1 insertion(+)
Index: b/drivers/ide/ppc/pmac.c
===================================================================
--- a/drivers/ide/ppc/pmac.c
+++ b/drivers/ide/ppc/pmac.c
@@ -1133,6 +1133,7 @@ pmac_ide_setup_device(pmac_ide_hwif_t *p
hwif->drives[0].autotune = IDE_TUNE_AUTO;
hwif->drives[1].autotune = IDE_TUNE_AUTO;
hwif->host_flags = IDE_HFLAG_SET_PIO_MODE_KEEP_DMA |
+ IDE_HFLAG_PIO_NO_DOWNGRADE |
IDE_HFLAG_POST_SET_MODE;
hwif->pio_mask = ATA_PIO4;
hwif->set_pio_mode = pmac_ide_set_pio_mode;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 2/18] ide-pmac: skip conservative PIO "downgrade"
2007-11-04 23:17 [PATCH 2/18] ide-pmac: skip conservative PIO "downgrade" Bartlomiej Zolnierkiewicz
@ 2007-11-04 23:35 ` Benjamin Herrenschmidt
2007-11-06 11:30 ` Sergei Shtylyov
1 sibling, 0 replies; 3+ messages in thread
From: Benjamin Herrenschmidt @ 2007-11-04 23:35 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz; +Cc: linux-ide, Mikael Pettersson
On Mon, 2007-11-05 at 00:17 +0100, Bartlomiej Zolnierkiewicz wrote:
>
> We can skip conservative PIO "downgrade" (PIO3 becomes PIO2 etc.) on PMAC.
>
> Problem reported by Mikael.
>
> Cc: Mikael Pettersson <mikpe@it.uu.se>
Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> ---
> drivers/ide/ppc/pmac.c | 1 +
> 1 file changed, 1 insertion(+)
>
> Index: b/drivers/ide/ppc/pmac.c
> ===================================================================
> --- a/drivers/ide/ppc/pmac.c
> +++ b/drivers/ide/ppc/pmac.c
> @@ -1133,6 +1133,7 @@ pmac_ide_setup_device(pmac_ide_hwif_t *p
> hwif->drives[0].autotune = IDE_TUNE_AUTO;
> hwif->drives[1].autotune = IDE_TUNE_AUTO;
> hwif->host_flags = IDE_HFLAG_SET_PIO_MODE_KEEP_DMA |
> + IDE_HFLAG_PIO_NO_DOWNGRADE |
> IDE_HFLAG_POST_SET_MODE;
> hwif->pio_mask = ATA_PIO4;
> hwif->set_pio_mode = pmac_ide_set_pio_mode;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 2/18] ide-pmac: skip conservative PIO "downgrade"
2007-11-04 23:17 [PATCH 2/18] ide-pmac: skip conservative PIO "downgrade" Bartlomiej Zolnierkiewicz
2007-11-04 23:35 ` Benjamin Herrenschmidt
@ 2007-11-06 11:30 ` Sergei Shtylyov
1 sibling, 0 replies; 3+ messages in thread
From: Sergei Shtylyov @ 2007-11-06 11:30 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz
Cc: linux-ide, Mikael Pettersson, Benjamin Herrenschmidt
Bartlomiej Zolnierkiewicz wrote:
> We can skip conservative PIO "downgrade" (PIO3 becomes PIO2 etc.) on PMAC.
> Problem reported by Mikael.
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
MBR, Sergei
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-11-06 11:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-11-04 23:17 [PATCH 2/18] ide-pmac: skip conservative PIO "downgrade" Bartlomiej Zolnierkiewicz
2007-11-04 23:35 ` Benjamin Herrenschmidt
2007-11-06 11:30 ` Sergei Shtylyov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).