* [PATCH 16/18] ide: remove redundant ->ide_dma_on call from set_using_dma()
@ 2007-11-04 23:33 Bartlomiej Zolnierkiewicz
2007-11-06 11:44 ` Sergei Shtylyov
0 siblings, 1 reply; 2+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2007-11-04 23:33 UTC (permalink / raw)
To: linux-ide
ide_set_dma() calls ->ide_dma_on method itself and returns zero
only if ->ide_dma_on call succeeded.
There should be no functionality changes caused by this patch.
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
---
drivers/ide/ide.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: b/drivers/ide/ide.c
===================================================================
--- a/drivers/ide/ide.c
+++ b/drivers/ide/ide.c
@@ -846,7 +846,7 @@ int set_using_dma(ide_drive_t *drive, in
if (arg) {
hwif->dma_off_quietly(drive);
- if (ide_set_dma(drive) || hwif->ide_dma_on(drive))
+ if (ide_set_dma(drive))
err = -EIO;
} else
ide_dma_off(drive);
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 16/18] ide: remove redundant ->ide_dma_on call from set_using_dma()
2007-11-04 23:33 [PATCH 16/18] ide: remove redundant ->ide_dma_on call from set_using_dma() Bartlomiej Zolnierkiewicz
@ 2007-11-06 11:44 ` Sergei Shtylyov
0 siblings, 0 replies; 2+ messages in thread
From: Sergei Shtylyov @ 2007-11-06 11:44 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz; +Cc: linux-ide
Bartlomiej Zolnierkiewicz wrote:
> ide_set_dma() calls ->ide_dma_on method itself and returns zero
> only if ->ide_dma_on call succeeded.
> There should be no functionality changes caused by this patch.
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
MBR, Sergei
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-11-06 11:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-11-04 23:33 [PATCH 16/18] ide: remove redundant ->ide_dma_on call from set_using_dma() Bartlomiej Zolnierkiewicz
2007-11-06 11:44 ` Sergei Shtylyov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).