* [PATCH 18/18] ide: remove redundant DMA blacklist check from __ide_dma_on()
@ 2007-11-04 23:34 Bartlomiej Zolnierkiewicz
2007-11-06 12:01 ` Sergei Shtylyov
0 siblings, 1 reply; 2+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2007-11-04 23:34 UTC (permalink / raw)
To: linux-ide
->ide_dma_on method is called only after successful ide_dma_check() call
(ide_dma_check()->ide_tune_dma() checks DMA blacklist) or if drive->using_dma
has been previously enabled for a given device (->ide_dma_on is the only place
which sets drive->using_dma to '1').
There should be no functionality changes caused by this patch.
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
---
drivers/ide/ide-dma.c | 4 ----
1 file changed, 4 deletions(-)
Index: b/drivers/ide/ide-dma.c
===================================================================
--- a/drivers/ide/ide-dma.c
+++ b/drivers/ide/ide-dma.c
@@ -490,10 +490,6 @@ EXPORT_SYMBOL(ide_dma_host_on);
int __ide_dma_on (ide_drive_t *drive)
{
- /* consult the list of known "bad" drives */
- if (__ide_dma_bad_drive(drive))
- return 1;
-
drive->using_dma = 1;
ide_toggle_bounce(drive, 1);
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH 18/18] ide: remove redundant DMA blacklist check from __ide_dma_on()
2007-11-04 23:34 [PATCH 18/18] ide: remove redundant DMA blacklist check from __ide_dma_on() Bartlomiej Zolnierkiewicz
@ 2007-11-06 12:01 ` Sergei Shtylyov
0 siblings, 0 replies; 2+ messages in thread
From: Sergei Shtylyov @ 2007-11-06 12:01 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz; +Cc: linux-ide
Bartlomiej Zolnierkiewicz wrote:
> ->ide_dma_on method is called only after successful ide_dma_check() call
> (ide_dma_check()->ide_tune_dma() checks DMA blacklist) or if drive->using_dma
> has been previously enabled for a given device (->ide_dma_on is the only place
> which sets drive->using_dma to '1').
> There should be no functionality changes caused by this patch.
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
MBR, Sergei
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-11-06 12:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-11-04 23:34 [PATCH 18/18] ide: remove redundant DMA blacklist check from __ide_dma_on() Bartlomiej Zolnierkiewicz
2007-11-06 12:01 ` Sergei Shtylyov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).