From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH 1/2] sl82c105: program DMA/PIO timings in ->dma_start/->ide_dma_end
Date: Tue, 06 Nov 2007 15:21:59 +0300 [thread overview]
Message-ID: <47305C67.7080502@ru.mvista.com> (raw)
In-Reply-To: <200711060026.51049.bzolnier@gmail.com>
Bartlomiej Zolnierkiewicz wrote:
> * Program DMA timings in sl82c105_dma_start() (->dma_start method)
> before starting DMA transfer.
> * Add sl82c105_dma_end() (->ide_dma_end method) to switch back to
> PIO timings when DMA transfer is complete.
> * In sl82c105_set_pio_mode() program timings regardless of ->using_dma
> setting and in sl82c105_set_dma_mode() only cache the new timings.
> * Remove no longer needed sl82c105_{ide_dma_on,off_quietly}().
Well, the right fix would have been to merge PIO/DMA timings -- but I
must admit that I have nearly forgotten about my existing but unfinished
version by now. :-|
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
MBR, Sergei
prev parent reply other threads:[~2007-11-06 12:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-05 23:26 [PATCH 1/2] sl82c105: program DMA/PIO timings in ->dma_start/->ide_dma_end Bartlomiej Zolnierkiewicz
2007-11-06 12:21 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47305C67.7080502@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).