From: Mark Lord <liml@rtr.ca>
To: Jeff Garzik <jeff@garzik.org>
Cc: Jeff Garzik <jgarzik@pobox.com>, Tejun Heo <htejun@gmail.com>,
Alan Cox <alan@redhat.com>,
IDE/ATA development list <linux-ide@vger.kernel.org>
Subject: Re: [PATCH 4/4] libata sata_qstor conversion to new error handling (EH).
Date: Wed, 07 Nov 2007 18:32:29 -0500 [thread overview]
Message-ID: <47324B0D.9060706@rtr.ca> (raw)
In-Reply-To: <20071107232721.GB26706@havoc.gtf.org>
Jeff Garzik wrote:
> On Wed, Nov 07, 2007 at 10:54:15AM -0500, Mark Lord wrote:
>> sata_qstor conversion to new error handling (EH).
>>
>> Convert sata_qstor to use the newer libata EH mechanisms.
>> Based on earlier work by Jeff Garzik.
>>
>> This belongs in 2.6.24.
>>
>> Signed-off-by: Mark Lord <mlord@pobox.com>
>
> Did you test this with both device probe ("it works") and at least
> one device error?
Yes, all four patches tested and working here.
I think there's two of us on the planet using that board with Linux. :)
The EH still isn't perfect -- never recovers from stuck-DRQ,
and SG_IO WRITEs don't work. That's really no different from
the existing 2.6.24 version. Regular I/O looks fine.
And this way it stops spamming the syslogs with the new WARN_ON()
calls in libata every time it noticed we didn't have the new EH hooks.
next prev parent reply other threads:[~2007-11-07 23:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-07 15:51 [PATCH 1/4] libata sata_qstor fix oops on rmmod Mark Lord
2007-11-07 15:52 ` [PATCH 2/4] libata sata_qstor nuke idle state Mark Lord
2007-11-08 18:14 ` Jeff Garzik
2007-11-07 15:53 ` [PATCH 3/4] libata sata_qstor workaround for spurious interrupts Mark Lord
2007-11-07 15:54 ` [PATCH 4/4] libata sata_qstor conversion to new error handling (EH) Mark Lord
2007-11-07 23:27 ` Jeff Garzik
2007-11-07 23:32 ` Mark Lord [this message]
2007-11-07 23:36 ` Mark Lord
2007-11-07 23:45 ` Jeff Garzik
2007-11-07 23:58 ` Mark Lord
2007-11-07 16:24 ` [PATCH 1/4] libata sata_qstor fix oops on rmmod Mark Lord
2007-11-08 2:30 ` Tejun Heo
2007-11-08 13:45 ` Mark Lord
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47324B0D.9060706@rtr.ca \
--to=liml@rtr.ca \
--cc=alan@redhat.com \
--cc=htejun@gmail.com \
--cc=jeff@garzik.org \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).