From: Tejun Heo <htejun@gmail.com>
To: Mark Lord <liml@rtr.ca>
Cc: Jeff Garzik <jgarzik@pobox.com>, Alan Cox <alan@redhat.com>,
IDE/ATA development list <linux-ide@vger.kernel.org>
Subject: Re: [PATCH 1/4] libata sata_qstor fix oops on rmmod
Date: Thu, 08 Nov 2007 11:30:45 +0900 [thread overview]
Message-ID: <473274D5.9030705@gmail.com> (raw)
In-Reply-To: <4731DF06.3050202@rtr.ca>
Mark Lord wrote:
> sata_qstor fix oops on rmmod.
>
> sata_qstor likes to disable the chip on module unload,
> so it provides a libata "host_stop" method to do this.
> But in recent kernels, this routine is now called too late,
> after the PCI mmio resources have already been released.
> Which produces an oops.
>
> This really needs to be fixed higher up.
> For an interim workaround, we disable this function for now.
Ah.. you're right. port and host stop should be called before any host
resource is torn down. I'll submit a patch soon. Thanks.
--
tejun
next prev parent reply other threads:[~2007-11-08 2:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-07 15:51 [PATCH 1/4] libata sata_qstor fix oops on rmmod Mark Lord
2007-11-07 15:52 ` [PATCH 2/4] libata sata_qstor nuke idle state Mark Lord
2007-11-08 18:14 ` Jeff Garzik
2007-11-07 15:53 ` [PATCH 3/4] libata sata_qstor workaround for spurious interrupts Mark Lord
2007-11-07 15:54 ` [PATCH 4/4] libata sata_qstor conversion to new error handling (EH) Mark Lord
2007-11-07 23:27 ` Jeff Garzik
2007-11-07 23:32 ` Mark Lord
2007-11-07 23:36 ` Mark Lord
2007-11-07 23:45 ` Jeff Garzik
2007-11-07 23:58 ` Mark Lord
2007-11-07 16:24 ` [PATCH 1/4] libata sata_qstor fix oops on rmmod Mark Lord
2007-11-08 2:30 ` Tejun Heo [this message]
2007-11-08 13:45 ` Mark Lord
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=473274D5.9030705@gmail.com \
--to=htejun@gmail.com \
--cc=alan@redhat.com \
--cc=jgarzik@pobox.com \
--cc=liml@rtr.ca \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).