Re: [PATCH 1/4] libata sata_qstor fix oops on rmmod

[Mark Lord <liml@rtr.ca>]

Mark Lord wrote:
> sata_qstor fix oops on rmmod.
> 
> sata_qstor likes to disable the chip on module unload,
> so it provides a libata "host_stop" method to do this.
> But in recent kernels, this routine is now called too late,
> after the PCI mmio resources have already been released.
> Which produces an oops.
> 
> This really needs to be fixed higher up.
> For an interim workaround, we disable this function for now.
> 
> This belongs in 2.6.24.
> 
> Signed-off-by:  Mark Lord <mlord@pobox.com>
> ---
> 
> --- old/drivers/ata/sata_qstor.c    2007-10-12 12:43:44.000000000 -0400
> +++ linux/drivers/ata/sata_qstor.c    2007-11-06 22:32:34.000000000 -0500
> @@ -523,10 +523,20 @@
..

Tejun Heo wrote:
>[PATCH #upstream-fixes] libata: port and host should be stopped before hardware resources are released
..

Once Tejun's fix is applied, this particular sata_qstor patch [1/4]
is no longer necessary and should be dropped.

-ml