linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Török Edwin" <edwintorok@gmail.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Jeff Garzik <jeff@garzik.org>, Mark Lord <liml@rtr.ca>,
	Riki Oktarianto <rkoktarianto@gmail.com>,
	linux-kernel@vger.kernel.org, Greg Kroah-Hartman <gregkh@suse.de>,
	linux-ide@vger.kernel.org
Subject: Re: [PATCH] Add quirk to set AHCI mode on ICH boards
Date: Fri, 09 Nov 2007 16:49:16 +0200	[thread overview]
Message-ID: <4734736C.5060003@gmail.com> (raw)
In-Reply-To: <20071109120425.543971bf@the-village.bc.nu>

Alan Cox wrote:
> On Thu, 8 Nov 2007 22:46:22 -0500
> Jeff Garzik <jeff@garzik.org> wrote:
>
>   
>> On Thu, Nov 08, 2007 at 10:29:37PM -0500, Mark Lord wrote:
>>     
>>> And I might even privately patch my own kernels to map the ACHI BAR
>>> in the cases where the BIOS didn't...
>>>       
>> The inability to do this in the general case is the main reason why
>> AHCI was not unconditionally enabled, even in IDE mode, when it was
>> originally added...  :/
>>     
>
> We've done it all the time for various devices without problems (eg S3
> video cards). I'd like to see it go in - although perhaps attached to a
> force_ahci boot param initially
>   

There is one problem with force enabling ahci. You'll loose the CDROM on
Dell laptops.
Prior to force-enabling ahci there is one "device" that sees the 2 sata
channels, and the 2 ide channels.
When you force-enable ahci, this device becomes the ahci controller (it
changes the device id),
and the IDE controller will appear as a separate new device (with
another device id), but it is disabled.

There are registers on the ICH7 that allows you to set enabled/disabled
status, but according to the documentation you should not enable a
device after it has been disabled. In practice I couldn't get the CDROM
to get re-enabled:
* either nothing happend
* spurious irqs were sent that nobody handles, unless I used irq=poll;
but still no cdrom.

Force-enabling AHCI, and not trying to enable the CDROM works, although
I occasionally got NCQ errors.

For a (long) discussion see this thread on the powertop mailing list:
http://www.bughost.org/pipermail/power/2007-June/000533.html
http://www.bughost.org/pipermail/power/2007-June/000573.html

And there is also another slightly different approach:
http://mjg59.livejournal.com/76062.html

Best regards,
--Edwin







  reply	other threads:[~2007-11-09 14:49 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20071109020235.GA2031@ceren>
2007-11-09  2:31 ` [PATCH] Add quirk to set AHCI mode on ICH boards Jeff Garzik
2007-11-09  3:29   ` Mark Lord
2007-11-09  3:46     ` Jeff Garzik
2007-11-09  4:44       ` Mark Lord
2007-11-09  4:57         ` Jeff Garzik
2007-11-09 15:02           ` Arjan van de Ven
2007-11-09 12:04       ` Alan Cox
2007-11-09 14:49         ` Török Edwin [this message]
2007-11-09 22:38           ` Riki Oktarianto
2007-11-09 23:32         ` Matthias Schniedermeyer
2007-11-10  3:08           ` Jeff Garzik
2007-11-10 11:20             ` Matthias Schniedermeyer
2007-11-10 11:26             ` Matthias Schniedermeyer
2007-11-10 18:01           ` Mark Lord
2007-11-10 18:38             ` Matthias Schniedermeyer
2007-11-11 14:05               ` Thorsten Leemhuis
2007-11-11 18:24                 ` Matthias Schniedermeyer
2007-11-10  3:05         ` Jeff Garzik
2007-11-10  3:54           ` Theodore Tso
2007-11-10  3:57             ` Jeff Garzik
2007-11-10 18:37           ` Allen Martin
2007-11-10 19:04             ` Jeff Garzik
2007-11-13  7:27               ` Allen Martin
2007-11-13 15:27                 ` Alan Cox
2007-11-14 18:35                   ` Allen Martin
2007-11-14 18:46                     ` Mark Lord
2007-11-14 18:58                       ` Greg KH
2007-11-09 12:45   ` Riki Oktarianto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4734736C.5060003@gmail.com \
    --to=edwintorok@gmail.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=gregkh@suse.de \
    --cc=jeff@garzik.org \
    --cc=liml@rtr.ca \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rkoktarianto@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).