From: Mark Lord <liml@rtr.ca>
To: albertl@mail.com
Cc: Jeff Garzik <jeff@garzik.org>, Tejun Heo <htejun@gmail.com>,
linux-ide@vger.kernel.org, Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [PATCH] libata: workaround DRQ=1 ERR=1 for ATAPI tape drives
Date: Tue, 13 Nov 2007 09:16:30 -0500 [thread overview]
Message-ID: <4739B1BE.7080109@rtr.ca> (raw)
In-Reply-To: <4739AB5B.7000703@rtr.ca>
Mark Lord wrote:
> ..
> NAK. There's no guarantee that the next command after an error
> will always be REQUEST_SENSE. Or is there?
>
> I think we should just ignore the ERR bit when DRQ is set for PACKET
> command.
> Period. Possibly only for tape drives (since they all seem to do this),
> and maybe not for non-tape drives.
..
Note also that if we already *know* that this ia an ATAPI device,
then we *know* that it will accept the PACKET opcode without error,
so there is no reason to even look at the ERR bit until after
the packet CDB has been transferred.
But I still think this should only apply to tapes for now.
next prev parent reply other threads:[~2007-11-13 14:16 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-22 9:24 ATA tape drive STT3401A needs DRQ HSM workaround too Tejun Heo
2007-10-22 9:31 ` Alan Cox
2007-10-22 9:30 ` Tejun Heo
2007-10-22 14:18 ` Mark Lord
2007-10-22 18:37 ` Jeff Garzik
2007-10-22 22:36 ` Mark Lord
2007-11-13 10:08 ` Albert Lee
2007-11-13 10:30 ` [PATCH] libata: workaround DRQ=1 ERR=1 for ATAPI tape drives Albert Lee
2007-11-13 10:35 ` Tejun Heo
2007-11-13 13:49 ` Mark Lord
2007-11-13 14:16 ` Mark Lord [this message]
2007-11-13 15:14 ` Alan Cox
2007-11-13 17:24 ` Mark Lord
2007-11-13 18:12 ` Alan Cox
2007-11-13 18:22 ` Mark Lord
2007-11-14 2:00 ` Tejun Heo
2007-11-14 6:13 ` [PATCH 1/2] " Albert Lee
2007-11-14 12:19 ` Alan Cox
2007-11-15 0:32 ` Tejun Heo
2007-11-14 6:20 ` [PATCH 2/2] libata: use ATA_HORKAGE_STUCK_ERR " Albert Lee
2007-11-15 0:33 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4739B1BE.7080109@rtr.ca \
--to=liml@rtr.ca \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=albertl@mail.com \
--cc=htejun@gmail.com \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).