From: Mark Lord <liml@rtr.ca>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: albertl@mail.com, Jeff Garzik <jeff@garzik.org>,
Tejun Heo <htejun@gmail.com>,
linux-ide@vger.kernel.org
Subject: Re: [PATCH] libata: workaround DRQ=1 ERR=1 for ATAPI tape drives
Date: Tue, 13 Nov 2007 13:22:11 -0500 [thread overview]
Message-ID: <4739EB53.5010206@rtr.ca> (raw)
In-Reply-To: <20071113181257.24ab95dd@the-village.bc.nu>
Alan Cox wrote:
> On Tue, 13 Nov 2007 12:24:45 -0500
> Mark Lord <liml@rtr.ca> wrote:
>
>> Alan Cox wrote:
>>>> NAK. There's no guarantee that the next command after an error
>>>> will always be REQUEST_SENSE. Or is there?
>>> For that device over ATAPI I believe the guarantee is there, the same as
>>> for SCSI.
>> ..
>>
>> Even for SG_IO w/o requesting sense data?
>
> Thats a very good question. Yes we might need to ignore ERR at that
> point. Another possibility would be to notice if ERR seems to be stuck
> after we are finished so we know for next time.
..
ERR should stay set until the next command has been written to the device.
So we could try and be clever to ignore ERR after PACKET, before CDB, only
if it was set by previous command.
Sounds a bit complex.
Just (unconditionally for tape) ignoring it between PACKET and CDB might be simpler.
Cheers
next prev parent reply other threads:[~2007-11-13 18:22 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-22 9:24 ATA tape drive STT3401A needs DRQ HSM workaround too Tejun Heo
2007-10-22 9:31 ` Alan Cox
2007-10-22 9:30 ` Tejun Heo
2007-10-22 14:18 ` Mark Lord
2007-10-22 18:37 ` Jeff Garzik
2007-10-22 22:36 ` Mark Lord
2007-11-13 10:08 ` Albert Lee
2007-11-13 10:30 ` [PATCH] libata: workaround DRQ=1 ERR=1 for ATAPI tape drives Albert Lee
2007-11-13 10:35 ` Tejun Heo
2007-11-13 13:49 ` Mark Lord
2007-11-13 14:16 ` Mark Lord
2007-11-13 15:14 ` Alan Cox
2007-11-13 17:24 ` Mark Lord
2007-11-13 18:12 ` Alan Cox
2007-11-13 18:22 ` Mark Lord [this message]
2007-11-14 2:00 ` Tejun Heo
2007-11-14 6:13 ` [PATCH 1/2] " Albert Lee
2007-11-14 12:19 ` Alan Cox
2007-11-15 0:32 ` Tejun Heo
2007-11-14 6:20 ` [PATCH 2/2] libata: use ATA_HORKAGE_STUCK_ERR " Albert Lee
2007-11-15 0:33 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4739EB53.5010206@rtr.ca \
--to=liml@rtr.ca \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=albertl@mail.com \
--cc=htejun@gmail.com \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).