From: Tejun Heo <htejun@gmail.com>
To: Mark Lord <liml@rtr.ca>
Cc: IDE/ATA development list <linux-ide@vger.kernel.org>,
Sebastian Kemper <sebastian_ml@gmx.net>,
Jeff Garzik <jgarzik@pobox.com>, Alan Cox <alan@redhat.com>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] libata-scsi: be tolerant of 12-byte ATAPI commands in 16-byte CDBs
Date: Thu, 15 Nov 2007 11:26:03 +0900 [thread overview]
Message-ID: <473BAE3B.2050906@gmail.com> (raw)
In-Reply-To: <473B33F7.7030708@rtr.ca>
Mark Lord wrote:
> Sebastian Kemper reported that issuing CD/DVD commands under libata
> is not fully compatible with ide-scsi. In particular, the
> GPCMD_SET_STREAMING
> was being rejected at the host level in some instances.
>
> The reason is that libata-scsi insists upon the cmd_len field exactly
> matching
> the SCSI opcode being issued, whereas ide-scsi tolerates 12-byte commands
> contained within a 16-byte (cmd_len) CDB.
>
> There doesn't seem to be a good reason for us to not be compatible there,
> so here is a patch to fix libata-scsi to permit SCSI opcodes so long as
> they fit within whatever size CDB is provided.
>
> Signed-off-by: Mark Lord <mlord@pobox.com>
applied to #tj-upstream-fixes.
--
tejun
prev parent reply other threads:[~2007-11-15 2:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20071113164323.GA5252@section-eight>
[not found] ` <20071113212230.77cadecd@the-village.bc.nu>
[not found] ` <20071113232859.GA4681@section-eight>
[not found] ` <473B0FA2.5000102@rtr.ca>
[not found] ` <20071114153852.GA9019@section-eight>
[not found] ` <473B1B83.9020103@rtr.ca>
2007-11-14 17:44 ` [PATCH] libata-scsi: be tolerant of 12-byte ATAPI commands in 16-byte CDBs Mark Lord
2007-11-14 17:50 ` Alan Cox
2007-11-15 2:26 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=473BAE3B.2050906@gmail.com \
--to=htejun@gmail.com \
--cc=alan@redhat.com \
--cc=jgarzik@pobox.com \
--cc=liml@rtr.ca \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sebastian_ml@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).