From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: linux-ide@vger.kernel.org, Mikael Starvik <starvik@axis.com>
Subject: Re: [PATCH 6/21] ide: move CONFIG_IDE_ETRAX to drivers/ide/Kconfig
Date: Wed, 21 Nov 2007 14:07:58 +0300 [thread overview]
Message-ID: <4744118E.2060607@ru.mvista.com> (raw)
In-Reply-To: <200711210010.47772.bzolnier@gmail.com>
Bartlomiej Zolnierkiewicz wrote:
>>>* Move ETRAX_IDE and friends from arch/cris/arch-{v10,v32}/drivers/Kconfig
>>> to drivers/ide/Kconfig.
>>>* Don't force selecting ide-disk and ide-cd device drivers
>>> (please handle this through defconfig if necessary).
>>>* Make ETRAX_IDE depend on BROKEN for the time being
>>> (it doesn't even compile currently).
>>>Cc: Mikael Starvik <starvik@axis.com>
>>>Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
>>>Index: b/drivers/ide/Kconfig
>>>===================================================================
>>>--- a/drivers/ide/Kconfig
>>>+++ b/drivers/ide/Kconfig
>>>@@ -870,6 +870,41 @@ config BLK_DEV_IDE_BAST
>>> Say Y here if you want to support the onboard IDE channels on the
>>> Simtec BAST or the Thorcom VR1000
>>>
>>>+config ETRAX_IDE
>>>+ bool "ETRAX IDE support"
>>>+ depends on CRIS && BROKEN
>>>+ select BLK_DEV_IDEDMA
>> Shouldn't it be the other way around, i.e. BLK_DEV_IDEDMA is enabled by
>>ETRAX_IDE as is the case with this option otherwise?
> Well, having a simple
> config BLK_DEV_IDEDMA
> bool
> and making the other options select it seems to be a better solution.
Well, then
Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
MBR, Sergei
prev parent reply other threads:[~2007-11-21 11:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-18 22:17 [PATCH 6/21] ide: move CONFIG_IDE_ETRAX to drivers/ide/Kconfig Bartlomiej Zolnierkiewicz
2007-11-19 19:04 ` Sergei Shtylyov
2007-11-20 23:10 ` Bartlomiej Zolnierkiewicz
2007-11-21 11:07 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4744118E.2060607@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=starvik@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).