[PATCH] libata-sff: tf_load

[PATCH] libata-sff: tf_load

[Alan Cox]

Jeff said he preferred that the SFF tf_load followed the spec and we
documented that anyone who needed different overrode it, rather than it
using the ->check_status methods. No driver relies on the current behaviour.

Signed-off-by: Alan Cox <alan@redhat.com>

diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.24-rc2-mm1/drivers/ata/libata-sff.c linux-2.6.24-rc2-mm1/drivers/ata/libata-sff.c
--- linux.vanilla-2.6.24-rc2-mm1/drivers/ata/libata-sff.c	2007-11-16 17:55:11.000000000 +0000
+++ linux-2.6.24-rc2-mm1/drivers/ata/libata-sff.c	2007-11-16 18:11:51.000000000 +0000
@@ -147,7 +147,9 @@
  *	@tf: ATA taskfile register set for storing input
  *
  *	Reads ATA taskfile registers for currently-selected device
- *	into @tf.
+ *	into @tf. Assumes the device has a fully SFF compliant task file
+ *	layout and behaviour. If you device does not (eg has a different
+ *	status method) then you will need to provide a replacement tf_read
  *
  *	LOCKING:
  *	Inherited from caller.
@@ -156,7 +158,7 @@
 {
 	struct ata_ioports *ioaddr = &ap->ioaddr;
 
-	tf->command = ata_chk_status(ap);
+	tf->command = ata_check_status(ap);
 	tf->feature = ioread8(ioaddr->error_addr);
 	tf->nsect = ioread8(ioaddr->nsect_addr);
 	tf->lbal = ioread8(ioaddr->lbal_addr);

Re: [PATCH] libata-sff: tf_load

[Jeff Garzik]

Alan Cox wrote:
> Jeff said he preferred that the SFF tf_load followed the spec and we
> documented that anyone who needed different overrode it, rather than it
> using the ->check_status methods. No driver relies on the current behaviour.
> 
> Signed-off-by: Alan Cox <alan@redhat.com>
> 
> diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.24-rc2-mm1/drivers/ata/libata-sff.c linux-2.6.24-rc2-mm1/drivers/ata/libata-sff.c
> --- linux.vanilla-2.6.24-rc2-mm1/drivers/ata/libata-sff.c	2007-11-16 17:55:11.000000000 +0000
> +++ linux-2.6.24-rc2-mm1/drivers/ata/libata-sff.c	2007-11-16 18:11:51.000000000 +0000
> @@ -147,7 +147,9 @@
>   *	@tf: ATA taskfile register set for storing input
>   *
>   *	Reads ATA taskfile registers for currently-selected device
> - *	into @tf.
> + *	into @tf. Assumes the device has a fully SFF compliant task file
> + *	layout and behaviour. If you device does not (eg has a different
> + *	status method) then you will need to provide a replacement tf_read
>   *
>   *	LOCKING:
>   *	Inherited from caller.
> @@ -156,7 +158,7 @@
>  {
>  	struct ata_ioports *ioaddr = &ap->ioaddr;
>  
> -	tf->command = ata_chk_status(ap);
> +	tf->command = ata_check_status(ap);

applied #upstream, thanks