Re: [PATCH RFC] sata_promise: make pdc_atapi_pkt() use values from qc->tf

[Tejun Heo <htejun@gmail.com>]

Hello,

Mikael Pettersson wrote:
>>  	buf[20] = (1 << 5) | ATA_REG_FEATURE;
>>  	buf[21] = feature;
>>  	buf[22] = (1 << 5) | ATA_REG_BYTEL;
>> -	buf[23] = nbytes & 0xFF;
>> +	buf[23] = qc->tf.lbam;
>>  	buf[24] = (1 << 5) | ATA_REG_BYTEH;
>> -	buf[25] = (nbytes >> 8) & 0xFF;
>> +	buf[25] = qc->tf.lbah;
> 
> The original code matches what Promise' own driver does, including
> the "set byte counter register to real transfer byte count" comment.
> It's certainly possible that if lbah/lbam don't match ->nbytes,
> the HW will go nuts. Their data sheets are very quiet about ATAPI.

Yeah, now core code sets the value properly and I just posted a patch to
massage transfer chunk size a bit so I was curious whether now
sata_promise can use the result of core layer instead.

> I can test your proposed change next weekend when I'm back to where
> my sata_promise test equipment is.

Thank you.

-- 
tejun