From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH 05/12] libata: xfer_mask is unsigned int not unsigned long Date: Tue, 27 Nov 2007 17:42:10 +0900 Message-ID: <474BD862.5080000@gmail.com> References: <1194327550227-git-send-email-htejun@gmail.com> <11943275501285-git-send-email-htejun@gmail.com> <47477AA2.40204@garzik.org> <47477AC6.1020104@garzik.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from wa-out-1112.google.com ([209.85.146.181]:27284 "EHLO wa-out-1112.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751461AbXK0ImV (ORCPT ); Tue, 27 Nov 2007 03:42:21 -0500 Received: by wa-out-1112.google.com with SMTP id v27so1141925wah for ; Tue, 27 Nov 2007 00:42:20 -0800 (PST) In-Reply-To: <47477AC6.1020104@garzik.org> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Jeff Garzik Cc: alan@lxorguk.ukuu.org.uk, linux-ide@vger.kernel.org Jeff Garzik wrote: > Jeff Garzik wrote: >> Tejun Heo wrote: >>> xfer_mask is unsigned int not unsigned long. Change ->mode_filter to >>> take and return unsigned int. >>> >>> While at it, rename @adev of ata_pci_default_filter() to @dev for >>> consistency. >>> >>> Signed-off-by: Tejun Heo >>> --- >>> drivers/ata/libata-sff.c | 5 +++-- >>> drivers/ata/pata_acpi.c | 2 +- >>> drivers/ata/pata_ali.c | 2 +- >>> drivers/ata/pata_hpt366.c | 2 +- >>> drivers/ata/pata_hpt37x.c | 4 ++-- >>> drivers/ata/pata_pdc2027x.c | 4 ++-- >>> drivers/ata/pata_scc.c | 2 +- >>> drivers/ata/pata_serverworks.c | 4 ++-- >>> include/linux/libata.h | 5 +++-- >>> 9 files changed, 16 insertions(+), 14 deletions(-) >> >> as I noted I permit unsigned long, which is a naturally aligned >> machine int on our platforms. > > er, s/permit/prefer/ Alright. I don't agree but don't have much problem either. Will update them the other way. -- tejun