From: Mark Lord <liml@rtr.ca>
To: Tejun Heo <htejun@gmail.com>
Cc: jeff@garzik.org, linux-ide@vger.kernel.org, bzolnier@gmail.com
Subject: Re: [PATCH 6/8] libata: adjust speed down rules
Date: Tue, 27 Nov 2007 20:10:47 -0500 [thread overview]
Message-ID: <474CC017.3040305@rtr.ca> (raw)
In-Reply-To: <474CA9C4.9040902@gmail.com>
Tejun Heo wrote:
> Mark Lord wrote:
>> Hi Tejun,
>>
>> Tejun Heo wrote:
>>> Mark Lord wrote:
>> ..
>>>> -- deliberate (or otherwise) errors via SG_IO will cause inappropriate
>>>> speed-downs.
>>> No, only device errors issued via block layer are considered for speed
>>> down (ATA_QCFLAG_IO). SG_IO commands will never trigger speed down
>>> unless the error is HSM or timeout.
>> ..
>>
>> Mmmm... what category is "device rejected the command" (ABRT) ?
>> Is that HSM ?
>
> Nope, that's UNK_DEV if the command is IO (came from block layer) and
> cat-0 (don't care) if it has come from SG_IO.
..
Perfect, thanks!
Last question: what about CD/DVD writers?
Are the data-out commands for those done via block, or via SG_IO ?
(my memory fails me here).
Do they ever get speed up/down based on WRITE errors ?
Cheers
next prev parent reply other threads:[~2007-11-28 1:10 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-27 10:28 [PATCHSET] libata: improve EH speed down logic, take #3 Tejun Heo
2007-11-27 10:28 ` [PATCH 1/8] libata: rearrange ATA_DFLAG_* Tejun Heo
2007-12-01 23:05 ` Jeff Garzik
2007-11-27 10:28 ` [PATCH 2/8] libata: implement protocol tests Tejun Heo
2007-12-01 23:06 ` Jeff Garzik
2007-11-27 10:28 ` [PATCH 3/8] libata: factor out ata_eh_schedule_probe() Tejun Heo
2007-11-27 10:28 ` [PATCH 4/8] libata: move ata_set_mode() to libata-eh.c Tejun Heo
2007-12-01 23:07 ` Jeff Garzik
2007-12-05 1:21 ` Tejun Heo
2007-11-27 10:28 ` [PATCH 5/8] libata: clean up EH speed down implementation Tejun Heo
2007-11-27 10:28 ` [PATCH 6/8] libata: adjust speed down rules Tejun Heo
2007-11-27 22:32 ` Mark Lord
2007-11-27 23:07 ` Tejun Heo
2007-11-27 23:33 ` Mark Lord
2007-11-27 23:35 ` Tejun Heo
2007-11-28 1:10 ` Mark Lord [this message]
2007-11-28 8:30 ` Tejun Heo
2007-11-27 10:28 ` [PATCH 7/8] libata: implement ATA_DFLAG_DUBIOUS_XFER Tejun Heo
2007-11-27 10:28 ` [PATCH 8/8] libata: implement fast speed down for unverified data transfer mode Tejun Heo
2007-12-01 23:07 ` Jeff Garzik
-- strict thread matches above, loose matches on Subject: below --
2007-11-05 5:45 [PATCHSET] libata: update EH speed down logic, take #2 Tejun Heo
2007-11-05 5:45 ` [PATCH 6/8] libata: adjust speed down rules Tejun Heo
2007-11-01 15:51 [PATCHSET] libata: update EH speed down logic Tejun Heo
2007-11-01 15:51 ` [PATCH 6/8] libata: adjust speed down rules Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=474CC017.3040305@rtr.ca \
--to=liml@rtr.ca \
--cc=bzolnier@gmail.com \
--cc=htejun@gmail.com \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).