* [PATCH 6/6] ide-pmac: use custom hwif->sg_max_nents only if DMA support is enabled
@ 2007-11-27 23:00 Bartlomiej Zolnierkiewicz
2007-11-27 23:36 ` Benjamin Herrenschmidt
2007-11-28 11:43 ` Sergei Shtylyov
0 siblings, 2 replies; 3+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2007-11-27 23:00 UTC (permalink / raw)
To: linux-ide; +Cc: Benjamin Herrenschmidt
Move setting hwif->sg_max_nents from pmac_ide_setup_device()
to pmac_ide_setup_dma().
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
---
drivers/ide/ppc/pmac.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Index: b/drivers/ide/ppc/pmac.c
===================================================================
--- a/drivers/ide/ppc/pmac.c
+++ b/drivers/ide/ppc/pmac.c
@@ -1133,8 +1133,6 @@ pmac_ide_setup_device(pmac_ide_hwif_t *p
hwif->noprobe = 0;
#endif /* CONFIG_PMAC_MEDIABAY */
- hwif->sg_max_nents = MAX_DCMDS;
-
#ifdef CONFIG_BLK_DEV_IDEDMA_PMAC
/* has a DBDMA controller channel */
if (pmif->dma_regs)
@@ -1751,6 +1749,8 @@ pmac_ide_setup_dma(pmac_ide_hwif_t *pmif
return;
}
+ hwif->sg_max_nents = MAX_DCMDS;
+
hwif->dma_host_set = &pmac_ide_dma_host_set;
hwif->dma_setup = &pmac_ide_dma_setup;
hwif->dma_exec_cmd = &pmac_ide_dma_exec_cmd;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 6/6] ide-pmac: use custom hwif->sg_max_nents only if DMA support is enabled
2007-11-27 23:00 [PATCH 6/6] ide-pmac: use custom hwif->sg_max_nents only if DMA support is enabled Bartlomiej Zolnierkiewicz
@ 2007-11-27 23:36 ` Benjamin Herrenschmidt
2007-11-28 11:43 ` Sergei Shtylyov
1 sibling, 0 replies; 3+ messages in thread
From: Benjamin Herrenschmidt @ 2007-11-27 23:36 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz; +Cc: linux-ide
On Wed, 2007-11-28 at 00:00 +0100, Bartlomiej Zolnierkiewicz wrote:
> Move setting hwif->sg_max_nents from pmac_ide_setup_device()
> to pmac_ide_setup_dma().
>
> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Ack.
> ---
> drivers/ide/ppc/pmac.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Index: b/drivers/ide/ppc/pmac.c
> ===================================================================
> --- a/drivers/ide/ppc/pmac.c
> +++ b/drivers/ide/ppc/pmac.c
> @@ -1133,8 +1133,6 @@ pmac_ide_setup_device(pmac_ide_hwif_t *p
> hwif->noprobe = 0;
> #endif /* CONFIG_PMAC_MEDIABAY */
>
> - hwif->sg_max_nents = MAX_DCMDS;
> -
> #ifdef CONFIG_BLK_DEV_IDEDMA_PMAC
> /* has a DBDMA controller channel */
> if (pmif->dma_regs)
> @@ -1751,6 +1749,8 @@ pmac_ide_setup_dma(pmac_ide_hwif_t *pmif
> return;
> }
>
> + hwif->sg_max_nents = MAX_DCMDS;
> +
> hwif->dma_host_set = &pmac_ide_dma_host_set;
> hwif->dma_setup = &pmac_ide_dma_setup;
> hwif->dma_exec_cmd = &pmac_ide_dma_exec_cmd;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 6/6] ide-pmac: use custom hwif->sg_max_nents only if DMA support is enabled
2007-11-27 23:00 [PATCH 6/6] ide-pmac: use custom hwif->sg_max_nents only if DMA support is enabled Bartlomiej Zolnierkiewicz
2007-11-27 23:36 ` Benjamin Herrenschmidt
@ 2007-11-28 11:43 ` Sergei Shtylyov
1 sibling, 0 replies; 3+ messages in thread
From: Sergei Shtylyov @ 2007-11-28 11:43 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz; +Cc: linux-ide, Benjamin Herrenschmidt
Bartlomiej Zolnierkiewicz wrote:
> Move setting hwif->sg_max_nents from pmac_ide_setup_device()
> to pmac_ide_setup_dma().
> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
MBR, Sergei
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-11-28 11:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-11-27 23:00 [PATCH 6/6] ide-pmac: use custom hwif->sg_max_nents only if DMA support is enabled Bartlomiej Zolnierkiewicz
2007-11-27 23:36 ` Benjamin Herrenschmidt
2007-11-28 11:43 ` Sergei Shtylyov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).