* Re: sata_mv fixes: coding style preference?
[not found] ` <474D3D8E.7030207@pobox.com>
@ 2007-11-28 14:19 ` Mark Lord
2007-11-28 16:00 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Mark Lord @ 2007-11-28 14:19 UTC (permalink / raw)
To: Jeff Garzik; +Cc: Tejun Heo, Alan Cox, IDE/ATA development list
(adding linux-ide to CC:)
Jeff Garzik wrote:
> Mark Lord wrote:
>
>> Below, I used inline functions to calculate the correct reg offsets
>> so that the rest of the code doesn't need any special if-stmts.
>> But another way to do it would be to just store the correct offsets
>> as new fields within the mv_host_priv struct. I suspect that method
>> would be better.
>
> Yes, store the offsets, you shouldn't need to call a function to
> calculate the same value over and over again. Simple, no branches added
> to the code, ...
..
Good, so we all agree on that!
And as it turns out, this patch (or the better version coming later)
fixes both of the Marvell 7042 problems reported here a couple of weeks ago:
1: Tom Morrison "hang with large file operations".
2. Hein-Pieter van Braam "PCI ERROR; PCI IRQ reason=0x00000000 highpoint rocketraid 2300 pci-e"
Tom has confirmed the fix, and I'm waiting to hear back from Hein-Pieter
even though I now have identical hardware here as what he has.
Jeff: This fix (one I reissue it) should go upstream for 2.6.24, if possible.
Right now the driver is guaranteed to fail on 7042, since it is hitting
reserved PCI addresses instead of valid registers.
Not a regression though, so your call.
But it does fix reported bugs, and really cannot hurt anything.
Cheers
^ permalink raw reply [flat|nested] 2+ messages in thread