From: Jeff Garzik <jeff@garzik.org>
To: kristen.c.accardi@intel.com
Cc: akpm@linux-foundation.org, linux-ide@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [patch] ata: ahci: Enclosure Management via LED rev2
Date: Sat, 01 Dec 2007 18:28:54 -0500 [thread overview]
Message-ID: <4751EE36.6050506@garzik.org> (raw)
In-Reply-To: <20071130163443.2feabc5d@appleyard>
Kristen Carlson Accardi wrote:
> Enclosure Management via LED
>
> This patch implements Enclosure Management via the LED protocol as specified
> in AHCI specification.
>
> Signed-off-by: Kristen Carlson Accardi <kristen.c.accardi@intel.com>
> ---
> This revision makes the change to the comment requested by Mark Lord,
> fixes some bugs in the bit shifting for writing the new led state,
> and implements a show function so that led status can be read as
> well as written.
Overall looks pretty good, from a technical review perspective.
Two worries:
1) exporting ata_scsi_find_dev(), and assuming a scsi device is
attached. the latter can be fixed by a !NULL check (and should be), but
its a bit of a layering violation since long term we want to make the
SCSI simulator optional for all ATA devices.
2) vaguely related to #1, I'm not so sure the attributes should be
implemented directly in ahci. if this __or something like it__ appears
on non-Intel hardware, the code should be somewhere more generic.
next prev parent reply other threads:[~2007-12-01 23:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-29 20:19 [patch] ata: ahci: Enclosure Management via LED Kristen Carlson Accardi
2007-12-01 0:34 ` [patch] ata: ahci: Enclosure Management via LED rev2 Kristen Carlson Accardi
2007-12-01 23:28 ` Jeff Garzik [this message]
2007-12-03 17:42 ` Kristen Carlson Accardi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4751EE36.6050506@garzik.org \
--to=jeff@garzik.org \
--cc=akpm@linux-foundation.org \
--cc=kristen.c.accardi@intel.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).