From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [patch] ata: ahci: Enclosure Management via LED rev2 Date: Sat, 01 Dec 2007 18:28:54 -0500 Message-ID: <4751EE36.6050506@garzik.org> References: <20071129121925.7d178915@appleyard> <20071130163443.2feabc5d@appleyard> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from srv5.dvmed.net ([207.36.208.214]:48305 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752560AbXLAX25 (ORCPT ); Sat, 1 Dec 2007 18:28:57 -0500 In-Reply-To: <20071130163443.2feabc5d@appleyard> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: kristen.c.accardi@intel.com Cc: akpm@linux-foundation.org, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Kristen Carlson Accardi wrote: > Enclosure Management via LED > > This patch implements Enclosure Management via the LED protocol as specified > in AHCI specification. > > Signed-off-by: Kristen Carlson Accardi > --- > This revision makes the change to the comment requested by Mark Lord, > fixes some bugs in the bit shifting for writing the new led state, > and implements a show function so that led status can be read as > well as written. Overall looks pretty good, from a technical review perspective. Two worries: 1) exporting ata_scsi_find_dev(), and assuming a scsi device is attached. the latter can be fixed by a !NULL check (and should be), but its a bit of a layering violation since long term we want to make the SCSI simulator optional for all ATA devices. 2) vaguely related to #1, I'm not so sure the attributes should be implemented directly in ahci. if this __or something like it__ appears on non-Intel hardware, the code should be somewhere more generic.