From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH 26/28] blk_end_request: changing ide-cd (take 3) Date: Mon, 03 Dec 2007 18:55:48 +0300 Message-ID: <47542704.2030602@ru.mvista.com> References: <20071130.183447.82055860.k-ueda@ct.jp.nec.com> <200712012342.52134.bzolnier@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from homer.mvista.com ([63.81.120.155]:38535 "EHLO imap.sh.mvista.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1750730AbXLCPzc (ORCPT ); Mon, 3 Dec 2007 10:55:32 -0500 In-Reply-To: <200712012342.52134.bzolnier@gmail.com> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Bartlomiej Zolnierkiewicz Cc: Kiyoshi Ueda , jens.axboe@oracle.com, bharrosh@panasas.com, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, linux-ide@vger.kernel.org, dm-devel@redhat.com, j-nomura@ce.jp.nec.com Bartlomiej Zolnierkiewicz wrote: > [PATCH] ide-cd: remove dead post_transform_command() > post_transform_command() call in cdrom_newpc_intr() has no effect because > it is done after the request has already been fully completed (rq->bio and > rq->data are always NULL). It was verified to be true regardless whether > INQUIRY command is using DMA or PIO to transfer data (by using modified > Tejun Heo's test-shortsg.c utility and adding a few printk()-s to ide-cd). > This was uncovered thanks to the "blk_end_request: full I/O completion > handler (take 3)" patch series from Kiyoshi Ueda. > Cc: jens.axboe@oracle.com > Cc: bharrosh@panasas.com > Cc: Kiyoshi Ueda Cc: Jun'ichi Nomura > Cc: Tejun Heo > Signed-off-by: Bartlomiej Zolnierkiewicz Acked-by: Sergei Shtylyov MBR, Sergei