From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Lord Subject: Re: [PATCH] sata_mv: Fix broken Marvell 7042 support. Date: Mon, 03 Dec 2007 14:12:03 -0500 Message-ID: <47545503.2070006@rtr.ca> References: <4751A2DA.6030403@rtr.ca> <20071203154749.6lah7pulw8ow0s84@email.syntomax.com> <47543C58.4040106@rtr.ca> <475447A0.2010101@rtr.ca> <47544B2F.5080007@pobox.com> <47544BAA.1020901@rtr.ca> <47544DA9.3070702@rtr.ca> <47544E74.3000608@rtr.ca> <20071203184204.1a2d7e35@the-village.bc.nu> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from rtr.ca ([76.10.145.34]:4637 "EHLO mail.rtr.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751595AbXLCTMG (ORCPT ); Mon, 3 Dec 2007 14:12:06 -0500 In-Reply-To: <20071203184204.1a2d7e35@the-village.bc.nu> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Alan Cox Cc: "Morrison, Tom" , Jeff Garzik , hp@syntomax.com, IDE/ATA development list , Tejun Heo , Alan Cox Alan Cox wrote: >> Confirmed. It writes "lgcy" + stuff into the 9th sector of the drive >> (for my "Legacy" drive). > > Thats quite nasty. Given that users putting volumes unpartitioned on > drives may see actual data corruption and loss perhaps we should > blacklist that controller variant with a large warning ? .. Yeah, that's quite obnoxious of Highpoint to just arbitrarily overwrite data. Some warnings would probably be quite useful here. We could log a WARNING the first few times (after boot) whenever we see software writing to that sector. Do this with a hack in mv_qc_prep or mv_qc_issue ? Or even just fail any write to that sector, so that the error gets propagated all the way back to usermode where it might be visible? Plus some big nasty "awareness" messages at boot regardless. If software never writes to it, then it should work fine. Except when drives are imported from somewhere else.. as I just discovered with my GRUB disk. Then the disk is already corrupted before our kernel is even loaded.