From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH 6/6] cmd64x: remove /proc/ide/cmd64x
Date: Tue, 04 Dec 2007 15:27:12 +0300 [thread overview]
Message-ID: <475547A0.4040809@ru.mvista.com> (raw)
In-Reply-To: <200712032255.08012.bzolnier@gmail.com>
Bartlomiej Zolnierkiewicz wrote:
> This belongs to user-space (and only if really needed).
Sigh, and why only I spent time fixing this code? :-)
> text data bss dec hex filename
> 3874 180 28 4082 ff2 drivers/ide/pci/cmd64x.o.before
> 2231 180 0 2411 96b drivers/ide/pci/cmd64x.o.after
> Additionaly to being bloat the code contained two bugs:
> - incorrect UDMA modes were reported for reserved values of UDIDETCR0/1 regs
Huh? What reserved values?
> - MRDMODE_BLK_CH0/1 bits are not defined on CMD643 and early CMD646 revisions
They're 0 there anyway, so the code worked properly.
> Also while at it remove unused CNTRL_DIS_RA0/1 defines.
> Cc: Sergei Shtylyov <sshtylyov@ru.mvista.com>
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
MBR, Sergei
next prev parent reply other threads:[~2007-12-04 12:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-03 21:55 [PATCH 6/6] cmd64x: remove /proc/ide/cmd64x Bartlomiej Zolnierkiewicz
2007-12-04 12:27 ` Sergei Shtylyov [this message]
2007-12-04 14:02 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=475547A0.4040809@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).