From: Jeff Garzik <jeff@garzik.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH] ata.h: Don't do a SATA check for 40wire_relaxed
Date: Tue, 04 Dec 2007 14:20:56 -0500 [thread overview]
Message-ID: <4755A898.7050707@garzik.org> (raw)
In-Reply-To: <20071119152434.45363e5d@the-village.bc.nu>
Alan Cox wrote:
> Without the valid bits at least one set of TSScorp drives report 0 in
> word 93 for PATA 40 wire, which we (and the specs) say actually means
> SATA. (The SATA version seems to report 80 wire...)
>
> Signed-off-by: Alan Cox <alan@redhat.com>
>
> diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.24-rc2-mm1/include/linux/ata.h linux-2.6.24-rc2-mm1/include/linux/ata.h
> --- linux.vanilla-2.6.24-rc2-mm1/include/linux/ata.h 2007-11-16 17:55:20.000000000 +0000
> +++ linux-2.6.24-rc2-mm1/include/linux/ata.h 2007-11-16 18:42:20.000000000 +0000
> @@ -560,8 +560,6 @@
>
> static inline int ata_drive_40wire_relaxed(const u16 *dev_id)
> {
> - if (ata_id_is_sata(dev_id))
> - return 0; /* SATA */
> if ((dev_id[93] & 0x2000) == 0x2000)
> return 0; /* 80 wire */
> return 1;
I've been thinking a lot about this, and I am really wondering if we
should fix up the IDENTIFY DEVICE page instead?
next prev parent reply other threads:[~2007-12-04 19:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-19 15:24 [PATCH] ata.h: Don't do a SATA check for 40wire_relaxed Alan Cox
2007-11-24 1:23 ` Jeff Garzik
2007-11-24 13:46 ` Alan Cox
2007-12-04 19:20 ` Jeff Garzik [this message]
2007-12-04 20:29 ` Alan Cox
-- strict thread matches above, loose matches on Subject: below --
2007-12-08 14:55 Peter Missel
2007-12-15 17:35 Peter Missel
2007-12-15 17:49 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4755A898.7050707@garzik.org \
--to=jeff@garzik.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).