From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH 8/21] ide: don't try to unregister interfaces if 'initializing' in ide_register_hw()
Date: Fri, 07 Dec 2007 19:49:50 +0300 [thread overview]
Message-ID: <475979AE.6000102@ru.mvista.com> (raw)
In-Reply-To: <200711182319.59382.bzolnier@gmail.com>
Bartlomiej Zolnierkiewicz wrote:
> Host drivers using ide_register_hw() and 'initializing == 1':
> * ide-pnp
> - depends on ISA
> * ide_arm
> - ARM arch specific
> - initialized before all other host drivers
> * ide-cris
> - CRIS arch specific => IDE_ARCH_OBSOLETE_INIT is not defined
> - broken
> * ide-h8300
> - H8300 arch specific => IDE_ARCH_OBSOLETE_INIT is not defined, no PCI
> * buddha/q40/gayle/macide/falconide
> - M68K arch specific => IDE_ARCH_OBSOLETE_INIT is not defined, no PCI
> Since the only host drivers which probe interfaces before the above ones are:
> * ali14xx/dtc2278/ht6560b/qd65xx/umc8672
> - depend on ISA
> - require IDE_ARCH_OBSOLETE_INIT=y to work
> * PCI ones
> - depend on PCI
> don't try to unregister interfaces if 'initializing == 1' in ide_register_hw()
> (it is possible that built-in host drivers will claim all IDE interfaces but
> later ide-pnp host driver will try to unregister them - this change fixes it).
> Also skip hwif->hold check if 'initializing == 1' since it is set only by:
> * pmac
> - PPC && PMAC specific => no ISA
> * au1xxx-ide
> - MIPS && SOC_AU1200 specific => no ISA
> and use ide_find_port() helper to find free ide_hwifs[] slot.
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
MBR, Sergei
prev parent reply other threads:[~2007-12-07 16:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-18 22:19 [PATCH 8/21] ide: don't try to unregister interfaces if 'initializing' in ide_register_hw() Bartlomiej Zolnierkiewicz
2007-12-07 16:49 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=475979AE.6000102@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).