From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH 9/9] ide-disk: use do_rw_taskfile()
Date: Fri, 07 Dec 2007 20:19:36 +0300 [thread overview]
Message-ID: <475980A8.1030708@ru.mvista.com> (raw)
In-Reply-To: <200711022305.44833.bzolnier@gmail.com>
Bartlomiej Zolnierkiewicz wrote:
> * Add IDE_TFLAG_DMA_PIO_FALLBACK taskfile flag to indicate the need
> to skip loading taskfile registers in do_rw_taskfile().
Hm, wouldn't it be better to call this flag IDE_TFLAG_SKIP_LOADING_TF then?
> * Export do_rw_taskfile().
> * Convert __ide_do_rw_disk() to use do_rw_taskfile().
> * Unexport ide_tf_load().
> * Unexport {pre_task_out,task_in}_intr() and make it static.
> * Remove incorrect comment about do_rw_taskfile() from <linux/ide.h>.
> There should be no functionality changes caused by this patch.
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
MBR, Sergei
prev parent reply other threads:[~2007-12-07 17:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-02 22:05 [PATCH 9/9] ide-disk: use do_rw_taskfile() Bartlomiej Zolnierkiewicz
2007-12-07 17:19 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=475980A8.1030708@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).