From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH 12/20] ide: use wait_drive_not_busy() in drive_cmd_intr()
Date: Mon, 10 Dec 2007 16:02:00 +0300 [thread overview]
Message-ID: <475D38C8.3020908@ru.mvista.com> (raw)
In-Reply-To: <200712092215.45956.bzolnier@gmail.com>
Bartlomiej Zolnierkiewicz wrote:
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
> Index: b/drivers/ide/ide-taskfile.c
> ===================================================================
> --- a/drivers/ide/ide-taskfile.c
> +++ b/drivers/ide/ide-taskfile.c
> @@ -260,7 +260,7 @@ static ide_startstop_t task_no_data_intr
> return ide_stopped;
> }
>
> -static u8 wait_drive_not_busy(ide_drive_t *drive)
> +u8 wait_drive_not_busy(ide_drive_t *drive)
> {
> ide_hwif_t *hwif = HWIF(drive);
> int retries;
I think you should remove the comment line below:
* (drive_cmd_intr waits that long).
MBR, Sergei
next prev parent reply other threads:[~2007-12-10 13:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-09 21:15 [PATCH 12/20] ide: use wait_drive_not_busy() in drive_cmd_intr() Bartlomiej Zolnierkiewicz
2007-12-10 13:02 ` Sergei Shtylyov [this message]
2007-12-12 21:34 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=475D38C8.3020908@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).