Re: [PATCH 20/30] blk_end_request: changing xsysace (take 4)

[Boaz Harrosh <bharrosh@panasas.com>]

On Wed, Dec 12 2007 at 19:06 +0200, Kiyoshi Ueda <k-ueda@ct.jp.nec.com> wrote:
> Hi,
> 
> On Wed, 12 Dec 2007 11:09:12 +0200, Boaz Harrosh <bharrosh@panasas.com> wrote:
>>> Index: 2.6.24-rc4/drivers/block/xsysace.c
>>> ===================================================================
>>> --- 2.6.24-rc4.orig/drivers/block/xsysace.c
>>> +++ 2.6.24-rc4/drivers/block/xsysace.c
>>> @@ -703,7 +703,7 @@ static void ace_fsm_dostate(struct ace_d
>>>  
>>>  		/* bio finished; is there another one? */
>>>  		i = ace->req->current_nr_sectors;
>>> -		if (end_that_request_first(ace->req, 1, i)) {
>>> +		if (__blk_end_request(ace->req, 0, i)) {
>> end_that_request_first() took sectors __blk_end_request() now takes
>> bytes
> 
> Thank you for pointing it out!  And I'm very sorry for the bug.
> I have checked all conversions between sectors and bytes through
> all patches again, and I found no other miss conversions.
> 
> Below is the revised patch for xsysace.
> 
> Thanks,
> Kiyoshi Ueda
> 
> 
NP, I know how it is, after you rebased your work for the 
"who's counting" times, you become blind. You need fresh
eyes to look at it. Thanks for doing all this.

Boaz