From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: linux-ide@vger.kernel.org,
Geert Uytterhoeven <geert@linux-m68k.org>,
Roman Zippel <zippel@linux-m68k.org>
Subject: Re: [PATCH 17/21] ide: drop 'initializing' argument from ide_register_hw()
Date: Thu, 13 Dec 2007 16:02:24 +0300 [thread overview]
Message-ID: <47612D60.4050408@ru.mvista.com> (raw)
In-Reply-To: <200712122236.46043.bzolnier@gmail.com>
Bartlomiej Zolnierkiewicz wrote:
>>>* Rename init_hwif_data() to ide_init_port_data() and export it.
>>>* For all users of ide_register_hw() with 'initializing' argument set
>>> hwif->present and hwif->hold are always zero so convert these host
>>> drivers to use ide_find_port()+ide_init_port_data()+ide_init_port_hw()
>>> instead (also no need for init_hwif_default() call since the setup
>>> done by it gets over-ridden by ide_init_port_data() call).
>> But init_hwif_default() gets called *after* ide_init_port_data() call, at
>>least in ide_register_hw()...
> This is a mistake in the patch description:
> s/ide_init_port_data/ide_init_port_hw/
> [ I fixed it locally ]
>>>* Drop 'initializing' argument from ide_register_hw().
>>>Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
>>>Index: b/drivers/ide/ide.c
>>>===================================================================
>>>--- a/drivers/ide/ide.c
>>>+++ b/drivers/ide/ide.c
>>>@@ -116,7 +116,7 @@ EXPORT_SYMBOL(ide_hwifs);
>>> /*
>>> * Do not even *think* about calling this!
>>> */
>> Isn't this comment being obsoleted by the patch?
> It is still valid because ide_init_port_data() destroys
> "hdx=" and "idex=" kernel parameters...
But the drivers are now calling it nevertheless...
> Thanks,
> Bart
MBR, Sergei
next prev parent reply other threads:[~2007-12-13 13:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-18 22:31 [PATCH 17/21] ide: drop 'initializing' argument from ide_register_hw() Bartlomiej Zolnierkiewicz
2007-12-11 18:18 ` Sergei Shtylyov
2007-12-12 21:36 ` Bartlomiej Zolnierkiewicz
2007-12-13 13:02 ` Sergei Shtylyov [this message]
2007-12-13 13:54 ` Bartlomiej Zolnierkiewicz
2007-12-13 16:07 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47612D60.4050408@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=bzolnier@gmail.com \
--cc=geert@linux-m68k.org \
--cc=linux-ide@vger.kernel.org \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).