From: Mark Lord <liml@rtr.ca>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: James.Bottomley@HansenPartnership.com, jens.axboe@oracle.com,
lkml@rtr.ca, matthew@wil.cx, linux-ide@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-mm@kvack.org, mel@csn.ul.ie
Subject: Re: QUEUE_FLAG_CLUSTER: not working in 2.6.24 ?
Date: Thu, 13 Dec 2007 19:47:14 -0500 [thread overview]
Message-ID: <4761D292.5030802@rtr.ca> (raw)
In-Reply-To: <4761D160.7060603@rtr.ca>
Mark Lord wrote:
> Andrew Morton wrote:
>> On Thu, 13 Dec 2007 19:30:00 -0500
>> Mark Lord <liml@rtr.ca> wrote:
>>
>>> Here's the commit that causes the regression:
>>>
>>> ...
>>>
>>> --- a/mm/page_alloc.c
>>> +++ b/mm/page_alloc.c
>>> @@ -760,7 +760,8 @@ static int rmqueue_bulk(struct zone *zone,
>>> unsigned int order,
>>> struct page *page = __rmqueue(zone, order, migratetype);
>>> if (unlikely(page == NULL))
>>> break;
>>> - list_add_tail(&page->lru, list);
>>> + list_add(&page->lru, list);
>>
>> well that looks fishy.
> ..
>
> Yeah. I missed that, and instead just posted a patch
> to search the list in reverse order, which seems to work for me.
>
> I'll try just reversing that line above here now.. gimme 5 minutes or so.
..
Yep, that works too. Alternative "improved" patch now posted.
next prev parent reply other threads:[~2007-12-14 0:47 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-13 18:36 QUEUE_FLAG_CLUSTER: not working in 2.6.24 ? Mark Lord
2007-12-13 18:37 ` Mark Lord
2007-12-13 18:42 ` Matthew Wilcox
2007-12-13 18:46 ` James Bottomley
2007-12-13 18:48 ` Mark Lord
2007-12-13 18:53 ` Matthew Wilcox
2007-12-13 19:03 ` Mark Lord
2007-12-13 19:26 ` Jens Axboe
2007-12-13 19:30 ` Mark Lord
2007-12-13 19:32 ` Mark Lord
2007-12-13 19:39 ` Jens Axboe
2007-12-13 19:42 ` Mark Lord
2007-12-13 19:53 ` Jens Axboe
2007-12-13 19:59 ` Mark Lord
2007-12-13 20:05 ` Jens Axboe
2007-12-13 20:02 ` Jens Axboe
2007-12-13 20:06 ` Mark Lord
2007-12-13 20:09 ` Jens Axboe
2007-12-13 20:14 ` Mark Lord
2007-12-13 20:18 ` Mark Lord
2007-12-13 20:21 ` Jens Axboe
2007-12-13 22:02 ` Andrew Morton
2007-12-13 22:15 ` James Bottomley
2007-12-13 22:29 ` Andrew Morton
2007-12-13 22:33 ` Mark Lord
2007-12-13 23:13 ` Mark Lord
2007-12-14 0:05 ` Mark Lord
2007-12-14 0:30 ` Mark Lord
2007-12-14 0:37 ` Andrew Morton
2007-12-14 0:42 ` Mark Lord
2007-12-14 0:46 ` [PATCH] fix page_alloc for larger I/O segments (improved) Mark Lord
2007-12-14 0:57 ` James Bottomley
2007-12-14 1:11 ` Andrew Morton
2007-12-14 2:23 ` Mark Lord
2007-12-14 17:42 ` Mel Gorman
2007-12-14 18:07 ` Mark Lord
2007-12-16 21:56 ` Mel Gorman
2007-12-14 18:13 ` Matthew Wilcox
2007-12-14 18:30 ` Mark Lord
2007-12-20 22:37 ` Matthew Wilcox
2007-12-14 0:47 ` Mark Lord [this message]
2007-12-14 11:50 ` QUEUE_FLAG_CLUSTER: not working in 2.6.24 ? Mel Gorman
2007-12-14 13:57 ` Mark Lord
2007-12-14 0:40 ` [PATCH] fix page_alloc for larger I/O segments Mark Lord
2007-12-14 1:03 ` Andrew Morton
2007-12-14 4:00 ` Matthew Wilcox
2007-12-13 22:17 ` QUEUE_FLAG_CLUSTER: not working in 2.6.24 ? Jens Axboe
2007-12-13 22:02 ` VM allocates pages in reverse order again Matthew Wilcox
2007-12-13 19:37 ` QUEUE_FLAG_CLUSTER: not working in 2.6.24 ? Jens Axboe
2007-12-13 19:53 ` Mark Lord
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4761D292.5030802@rtr.ca \
--to=liml@rtr.ca \
--cc=James.Bottomley@HansenPartnership.com \
--cc=akpm@linux-foundation.org \
--cc=jens.axboe@oracle.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-scsi@vger.kernel.org \
--cc=lkml@rtr.ca \
--cc=matthew@wil.cx \
--cc=mel@csn.ul.ie \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).