linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [patch 5/9] libata: add TOSHIBA MK1637GSX to spurious command completion list
@ 2007-12-14  0:01 akpm
  2007-12-14  4:47 ` Tejun Heo
  0 siblings, 1 reply; 2+ messages in thread
From: akpm @ 2007-12-14  0:01 UTC (permalink / raw)
  To: jeff; +Cc: linux-ide, akpm, lakostis, htejun, lakostis, thresh

From: "Konstantin A. Lepikhov" <lakostis@altlinux.org>

ata1.00: exception Emask 0x2 SAct 0x1 SErr 0x0 action 0x2 frozen
ata1.00: spurious completions during NCQ issue=0x0 SAct=0x1 FIS=004040a1:00000020
ata1.00: cmd 60/70:00:83:a6:f0/00:00:04:00:00/40 tag 0 cdb 0x0 data 57344 in

Device Model:     TOSHIBA MK1637GSX
Serial Number:    77VBT1CRT
Firmware Version: DL040D

Blacklist it.

Addresses http://bugzilla.kernel.org/show_bug.cgi?id=9410

Signed-off-by: Konstantin A. Lepikhov <lakostis@altlinux.ru>
Acked-by: Pavlov Konstantin <thresh@altlinux.ru>
Cc: Jeff Garzik <jeff@garzik.org>
Cc: Tejun Heo <htejun@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 drivers/ata/libata-core.c |    1 +
 1 file changed, 1 insertion(+)

diff -puN drivers/ata/libata-core.c~libata-add-toshiba-mk1637gsx-to-spurious-command-completion-list drivers/ata/libata-core.c
--- a/drivers/ata/libata-core.c~libata-add-toshiba-mk1637gsx-to-spurious-command-completion-list
+++ a/drivers/ata/libata-core.c
@@ -4152,6 +4152,7 @@ static const struct ata_blacklist_entry 
 	/* NCQ is broken */
 	{ "Maxtor *",		"BANC*",	ATA_HORKAGE_NONCQ },
 	{ "Maxtor 7V300F0",	"VA111630",	ATA_HORKAGE_NONCQ },
+	{ "TOSHIBA MK1637GSX",	"DL040D",	ATA_HORKAGE_NONCQ, },
 	{ "HITACHI HDS7250SASUN500G*", NULL,    ATA_HORKAGE_NONCQ },
 	{ "HITACHI HDS7225SBSUN250G*", NULL,    ATA_HORKAGE_NONCQ },
 	{ "ST380817AS",		"3.42",		ATA_HORKAGE_NONCQ },
_

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [patch 5/9] libata: add TOSHIBA MK1637GSX to spurious command completion list
  2007-12-14  0:01 [patch 5/9] libata: add TOSHIBA MK1637GSX to spurious command completion list akpm
@ 2007-12-14  4:47 ` Tejun Heo
  0 siblings, 0 replies; 2+ messages in thread
From: Tejun Heo @ 2007-12-14  4:47 UTC (permalink / raw)
  To: akpm; +Cc: jeff, linux-ide, lakostis, lakostis, thresh

akpm@linux-foundation.org wrote:
> From: "Konstantin A. Lepikhov" <lakostis@altlinux.org>
> 
> ata1.00: exception Emask 0x2 SAct 0x1 SErr 0x0 action 0x2 frozen
> ata1.00: spurious completions during NCQ issue=0x0 SAct=0x1 FIS=004040a1:00000020
> ata1.00: cmd 60/70:00:83:a6:f0/00:00:04:00:00/40 tag 0 cdb 0x0 data 57344 in
> 
> Device Model:     TOSHIBA MK1637GSX
> Serial Number:    77VBT1CRT
> Firmware Version: DL040D
> 
> Blacklist it.
> 
> Addresses http://bugzilla.kernel.org/show_bug.cgi?id=9410
> 
> Signed-off-by: Konstantin A. Lepikhov <lakostis@altlinux.ru>
> Acked-by: Pavlov Konstantin <thresh@altlinux.ru>
> Cc: Jeff Garzik <jeff@garzik.org>
> Cc: Tejun Heo <htejun@gmail.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

This one should go away.  Spurious NCQ completion was bogus.

Thanks.

-- 
tejun

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2007-12-14  4:47 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-12-14  0:01 [patch 5/9] libata: add TOSHIBA MK1637GSX to spurious command completion list akpm
2007-12-14  4:47 ` Tejun Heo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).