From: Tejun Heo <htejun@gmail.com>
To: Mark Lord <liml@rtr.ca>
Cc: jeff@garzik.org, hancockr@shaw.ca, linux-ide@vger.kernel.org
Subject: Re: [PATCH 7/9] libata-acpi: improve _GTF execution error handling and reporting
Date: Fri, 14 Dec 2007 23:50:23 +0900 [thread overview]
Message-ID: <4762982F.2060701@gmail.com> (raw)
In-Reply-To: <47629720.4010602@rtr.ca>
Mark Lord wrote:
> Tejun Heo wrote:
>> Mark Lord wrote:
>>> Tejun Heo wrote:
>>>> As _GTF commands can't transfer data, device error never signals
>>>> transfer error. It indicates that the device vetoed the operation, so
>>>> it's meaningless to retry.
>>> ..
>>>
>>> The SECURITY commands may pass a data block to the drive,
>>> containing the password required to unlock/freeze a drive.
>>> I suspect ACPI on many machines will issue such a command,
>>> and it does indeed transfer data (512 bytes).
>>
>> Surprise, ACPI _GTF can't do that. Don't ask me why. :-)
> ..
>
> Then why are we (going to be) filtering those op's (one of your patches) ?
Filtered ones are not LOCK / FREEZE LOCK commands which prevent further
changes. e.g. SET MAX FREEZE LOCK will prevent further size changes
using SET MAX [EXT]. It's bad for three reasons 1. it locks down drive
feature without user consent (e.g. can't unlock HPA) 2. it makes
debugging difficult by putting drives into different states 3. it just
doesn't serve any good.
--
tejun
next prev parent reply other threads:[~2007-12-14 14:50 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-14 6:15 [PATCHSET #upstram-fixes] libata-acpi: improve ACPI corner case handling Tejun Heo
2007-12-14 6:15 ` [PATCH 1/9] libata: drop const from struct ata_port param on ata_acpi_gtm/stm() Tejun Heo
2007-12-14 6:15 ` [PATCH 2/9] libata: update ata_*_printk() macros such that level can be a variable Tejun Heo
2007-12-14 6:15 ` [PATCH 3/9] libata: add more opcodes to ata.h Tejun Heo
2007-12-14 6:15 ` [PATCH 4/9] libata: implement ata_acpi_init_gtm() Tejun Heo
2007-12-14 6:15 ` [PATCH 5/9] libata: use init_gtm in ata_acpi_cbl_80wire() Tejun Heo
2007-12-14 6:15 ` [PATCH 6/9] libata-acpi: improve ACPI disabling Tejun Heo
2007-12-14 6:15 ` [PATCH 7/9] libata-acpi: improve _GTF execution error handling and reporting Tejun Heo
2007-12-14 14:12 ` Mark Lord
2007-12-14 14:15 ` Tejun Heo
2007-12-14 14:45 ` Mark Lord
2007-12-14 14:50 ` Tejun Heo [this message]
2007-12-14 14:54 ` Mark Lord
2007-12-14 6:15 ` [PATCH 8/9] libata-acpi: ignore _GTM failure during suspend Tejun Heo
2007-12-14 6:15 ` [PATCH 9/9] libata-acpi: implement _GTF command filtering and filter out LOCK commands Tejun Heo
2007-12-14 7:56 ` [PATCHSET #upstram-fixes] libata-acpi: improve ACPI corner case handling Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4762982F.2060701@gmail.com \
--to=htejun@gmail.com \
--cc=hancockr@shaw.ca \
--cc=jeff@garzik.org \
--cc=liml@rtr.ca \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).