From: Jeff Garzik <jeff@garzik.org>
To: Tejun Heo <htejun@gmail.com>
Cc: linux-ide@vger.kernel.org, alan@lxorguk.ukuu.org.uk, liml@rtr.ca,
albertl@mail.com, jens.axboe@oracle.com
Subject: Re: [PATCH 12/15] libata: make qc->nbytes include extra buffers
Date: Tue, 18 Dec 2007 16:44:03 -0500 [thread overview]
Message-ID: <47683F23.4020504@garzik.org> (raw)
In-Reply-To: <11968405981339-git-send-email-htejun@gmail.com>
Tejun Heo wrote:
> qc->nbytes didn't use to include extra buffers setup by libata core
> layer and my be odd. This patch makes qc->nbytes include any extra
> buffers setup by libata core layer and guaranteed to be aligned on 4
> byte boundary.
>
> This value is to be used to program the host controller. As this
> represents the actual length of buffer available to the controller and
> the controller must be able to deal with short transfers for ATAPI
> commands which can transfer variable length, this shouldn't break any
> controllers while making problems like rounding-down and controllers
> choking up on odd transfer bytes much less likely.
>
> The unmodified value is stored in new field qc->raw_nbytes.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
> ---
> drivers/ata/libata-core.c | 14 ++++++++++----
> include/linux/libata.h | 3 ++-
> 2 files changed, 12 insertions(+), 5 deletions(-)
applied 9-12 to #upstream
next prev parent reply other threads:[~2007-12-18 21:44 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-05 7:43 [PATCHSET] libata: improve ATAPI data transfer handling, take #3 Tejun Heo
2007-12-05 7:43 ` [PATCH 01/15] libata: make atapi_request_sense() use sg Tejun Heo
2007-12-18 21:30 ` Jeff Garzik
2007-12-05 7:43 ` [PATCH 02/15] libata: zero xfer length on ATAPI data xfer IRQ is HSM violation Tejun Heo
2007-12-06 6:44 ` Albert Lee
2007-12-05 7:43 ` [PATCH 03/15] libata: update atapi_eh_request_sense() such that lbam/lbah contains buffer size Tejun Heo
2007-12-05 7:43 ` [PATCH 04/15] cdrom: add more GPCMD_* constants Tejun Heo
2007-12-05 7:43 ` [PATCH 05/15] libata: rename ATA_PROT_ATAPI_* to ATAPI_PROT_* Tejun Heo
2007-12-18 21:35 ` Jeff Garzik
2007-12-05 7:43 ` [PATCH 06/15] libata: add ATAPI_* cmd types and implement atapi_cmd_type() Tejun Heo
2007-12-05 7:43 ` [PATCH 07/15] change-data_xfer Tejun Heo
2007-12-18 21:38 ` Jeff Garzik
2007-12-05 7:43 ` [PATCH 08/15] libata: improve ATAPI draining Tejun Heo
2007-12-06 6:47 ` Albert Lee
2007-12-18 21:41 ` Jeff Garzik
2007-12-05 7:43 ` [PATCH 09/15] libata: kill non-sg DMA interface Tejun Heo
2007-12-05 7:43 ` [PATCH 10/15] libata: change ATA_QCFLAG_DMAMAP semantics Tejun Heo
2007-12-05 7:43 ` [PATCH 11/15] libata: convert to chained sg Tejun Heo
2007-12-05 7:43 ` [PATCH 12/15] libata: make qc->nbytes include extra buffers Tejun Heo
2007-12-18 21:44 ` Jeff Garzik [this message]
2007-12-05 7:43 ` [PATCH 13/15] libata: implement ATAPI drain buffer Tejun Heo
2007-12-18 21:45 ` Jeff Garzik
2007-12-05 7:43 ` [PATCH 14/15] libata: implement ATAPI per-command-type DMA horkages Tejun Heo
2007-12-05 7:43 ` [PATCH 15/15] libata: use PIO for misc ATAPI commands Tejun Heo
2007-12-05 13:00 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47683F23.4020504@garzik.org \
--to=jeff@garzik.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=albertl@mail.com \
--cc=htejun@gmail.com \
--cc=jens.axboe@oracle.com \
--cc=liml@rtr.ca \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).