Re: [patch 9/9] pata_legacy: restructure and revamp

[Jeff Garzik <jeff@garzik.org>]

akpm@linux-foundation.org wrote:
> From: Alan Cox <alan@lxorguk.ukuu.org.uk>
> 
> Rework the pata_legacy driver to have an internal way to plug multiple
> legacy interface types and designs into the driver.
> 
> This driver supports
> 	- Generic legacy ISA on primary/secondary and tertiary ports
> 	- BIOS or jumper configured legacy ports
> 	- VLB controllers that snoop the mode set for PIO
> 		(Cirrus CLPD7220, Adaptec AIC25VL01)
> 	- Promise PDC20230
> 	- Holtek 6560A/B
> 	- Opti VLB controllers
> 	- QDI 6500/6580/6580DP controllers
> 
> The new driver also adds an "all" option so you can load all the PCI
> drivers you have, decide you have a controller that is totally unknown and
> then load pata_legacy all=1 to grab the primary/secondary ports as a last
> resort fallback.
> 
> TODO:
> 	Add ST412 support (needs some kind of geometry hook in libata core code)
> 	Winbond W83759A in programmable mode (aka DTC2278)
> 	Find more insane VLB controllers to support
> 
> This driver obsoletes pata_qdi, which can go once this is settled in.
> 
> Signed-off-by: Alan Cox <alan@redhat.com>
> Cc: Jeff Garzik <jeff@garzik.org>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
> 
>  drivers/ata/pata_legacy.c |  765 ++++++++++++++++++++++++++++--------
>  1 file changed, 607 insertions(+), 158 deletions(-)

ACK but needs rediffing